Bug 642435 - udev rules broken for pilot-link in f14: can't sync as a user
Summary: udev rules broken for pilot-link in f14: can't sync as a user
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pilot-link
Version: 14
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Ivana Varekova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 599639
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-10-12 22:18 UTC by Alex Lancaster
Modified: 2010-11-23 21:48 UTC (History)
6 users (show)

Fixed In Version: pilot-link-0.12.5-2.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of: 599639
Environment:
Last Closed: 2010-11-23 21:48:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
patch for pilot-link part of the issue (400 bytes, patch)
2010-11-02 09:44 UTC, Ivana Varekova
no flags Details | Diff
fixed patch (5.20 KB, patch)
2010-11-02 14:17 UTC, Ivana Varekova
no flags Details | Diff

Description Alex Lancaster 2010-10-12 22:18:02 UTC
+++ This bug was initially created as a clone of Bug #599639 +++

The issue described in the original bug that this is a clone of, appears to also affect pilot-link (just got around to installing F14 Beta and started testing pilot-link).  With the current version of pilot-link in f14, I cannot sync as a user (although I can sync using "pilot-link -p usb: -l" as root).

I suspect that this is because (as it was for the libmtp package) in recent udev. the "ENV{ACL_MANAGE}="1"" is now deprecated and should be removed from udev rules.  This is also noted that this fix would be necessary for pilot-link in yet another bug: bug #588660 comment #4.

I have tried changing the to ENV{ACL_MANAGE}="0" for my particular model in 69-pilot-link.rules and adding TAG+="udev-acl" but haven't had any luck as yet.

In any case, this should really be resolved before f14 is released.  If anybody knows the "correct solution", please let me know, I can will try to implement it.

Comment 1 Alex Lancaster 2010-10-12 22:51:35 UTC
Update: after changing all occurrences of:

ENV{ACL_MANAGE}="1"

to:

ENV{ACL_MANAGE}="0"

in the rules file, and then rebooting, synching as a user seems to work now.  I will work up a patch.  udev/acl hackers: let me know if this is the correct strategy.

Comment 2 Kevin Kofler 2010-10-19 21:03:18 UTC
Well, ENV{ACL_MANAGE}="0" is certainly not correct unless the rules changed again.

Comment 3 Alex Lancaster 2010-10-19 21:12:29 UTC
(In reply to comment #2)
> Well, ENV{ACL_MANAGE}="0" is certainly not correct unless the rules changed
> again.

Well, it definitely makes things work for me, and it appears to have been what was done to fix some of the other bugs.  What should the more correct solution be?  Just  ENV{ACL_MANAGE}!="0" as you suggest in bug 599639 comment #5?

Comment 4 Harald Hoyer 2010-10-29 14:06:03 UTC
Ok.. talked to the udev author...

Change ENV{ACL_MANAGE}="1" to ENV{ID_PDA}="1" and remove ENV{ACL_MANAGE}=="1", TAG+="udev-acl"

I will release an udev update, which will give all devices with 
ENV{ID_PDA}=="1" the ACLs.

Comment 5 Kevin Kofler 2010-10-31 22:40:47 UTC
For all the affected libraries: With the current udev in F14, ACL_MANAGE is not used anymore at all, so just TAG+="udev-acl" is likely to work.

> I will release an udev update, which will give all devices with 
> ENV{ID_PDA}=="1" the ACLs.

When will that update be issued? F14 will be released in 2 days and ACL setting is broken for many packages.

And are you going to add additional ENV{ID_*} variables for all the libraries that ask for one? Or should they just parasite ID_PDA even if they're not PDAs at all? Or set that udev-acl tag themselves (which is frowned upon)?

Comment 6 Ivana Varekova 2010-11-02 09:44:55 UTC
Created attachment 457128 [details]
patch for pilot-link part of the issue

Comment 7 Ivana Varekova 2010-11-02 09:47:08 UTC
Hello Harald, I just put here the patch which you suggests, please when will you fix the udev part? I don't see the update yet. Do you plan to do the same change in rawhide too?

Comment 8 Kevin Kofler 2010-11-02 12:28:53 UTC
Sorry, but that patch cannot be right.

> -ENV{ACL_MANAGE}=="1", TAG+="udev-acl"

That's the first part of what Harald Hoyer requested in comment #4.

> +ENV{ID_PDA}=="1"

But that line doesn't make sense. It is a check for ENV{ID_PDA}=="1" (a comparison) without any associated action. Please remove that line.

What he actually asked you to do is:
> Change ENV{ACL_MANAGE}="1" to ENV{ID_PDA}="1"
More precisely: change all instances of ENV{ACL_MANAGE}="1" in the rule file to ENV{ID_PDA}="1", i.e. s/ACL_MANAGE/ID_PDA/g.

Comment 9 Ivana Varekova 2010-11-02 14:17:59 UTC
Created attachment 457176 [details]
fixed patch

sorry fixed

Comment 10 Fedora Update System 2010-11-12 14:55:01 UTC
udev-161-6.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/udev-161-6.fc14

Comment 12 Alex Lancaster 2010-11-13 03:08:57 UTC
(In reply to comment #10)
> udev-161-6.fc14 has been submitted as an update for Fedora 14.
> https://admin.fedoraproject.org/updates/udev-161-6.fc14

Is the update to udev sufficient to fix this in pilot-link.  Or does there also need to be an associated update for pilot-link itself, in addition to the udev update?

Comment 13 Alex Lancaster 2010-11-13 03:10:36 UTC
(In reply to comment #12)

> Is the update to udev sufficient to fix this in pilot-link.  Or does there also
> need to be an associated update for pilot-link itself, in addition to the udev
> update?

And if so, that build should be added to this update as a single update with both udev + pilot-link before closing this bug.

Ivana: I can make the pilot-link build for f14 if you don't have time to backport from f15/rawhide.

Comment 14 Fedora Update System 2010-11-13 22:00:40 UTC
udev-161-6.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update udev'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/udev-161-6.fc14

Comment 15 Harald Hoyer 2010-11-15 11:07:11 UTC
(In reply to comment #12)
> (In reply to comment #10)
> > udev-161-6.fc14 has been submitted as an update for Fedora 14.
> > https://admin.fedoraproject.org/updates/udev-161-6.fc14
> 
> Is the update to udev sufficient to fix this in pilot-link.  Or does there also
> need to be an associated update for pilot-link itself, in addition to the udev
> update?

pilot-link would need the patch from comment 9

Comment 16 Ivana Varekova 2010-11-15 15:28:53 UTC
Thanks a lot Alex, I add it to fc14 version now.

Comment 17 Fedora Update System 2010-11-15 15:36:14 UTC
pilot-link-0.12.5-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/pilot-link-0.12.5-2.fc14

Comment 18 Ivana Varekova 2010-11-15 16:02:00 UTC
Fixed in pilot-link-0.12.5-2.fc15.

Comment 19 Fedora Update System 2010-11-15 22:19:30 UTC
pilot-link-0.12.5-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pilot-link'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/pilot-link-0.12.5-2.fc14

Comment 20 Fedora Update System 2010-11-16 23:14:35 UTC
udev-161-6.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Alex Lancaster 2010-11-17 03:59:08 UTC
Re-opening until pilot-link update is pushed to stable.

Comment 22 Fedora Update System 2010-11-23 21:48:45 UTC
pilot-link-0.12.5-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.