Bug 649319

Summary:	cannot upload binary config file
Product:	Red Hat Satellite 5	Reporter:	Tomas Lestach <tlestach>
Component:	Configuration Management	Assignee:	Tomas Lestach <tlestach>
Status:	CLOSED ERRATA	QA Contact:	Pavel Novotny <pnovotny>
Severity:	medium	Docs Contact:
Priority:	high
Version:	540	CC:	cperry, dyordano, mpoole, pnovotny
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Although RHN Satellite allows a user to upload binary configuration files, an error in a previous update caused this feature not to work. With this update, this error has been fixed, and uploading binary files no longer fails.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-12-16 15:45:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	646488

Description Tomas Lestach 2010-11-03 14:30:19 UTC

Description of problem:


Version-Release number of selected component (if applicable):
sat540

How reproducible:
always

Steps to Reproduce:
1. Create a config channel
2. Navigate to - Add Files - Upload File
3. Select binary as file type and select as "File to upload" select small binary file 
4. Set any Filename/Path and submit
  
Actual results:
no file was added to the config channel
WebUI shows following error messages:
Macro end tag is required.
Macro start tag is required.

Expected results:
Successful file upload

Additional info: looks like regression against 530

Comment 1 Tomas Lestach 2010-11-03 14:33:25 UTC

One more related issue:
if uploading a text file and then trying to set the file mode to "binary", getting the same result as described in #Description.

Comment 2 Tomas Lestach 2010-11-03 18:24:38 UTC

fixed both issues

spacewalk.git: 1f34d41208008af469b75e3a9caa21c53ae59b32

Comment 5 Pavel Novotny 2010-12-07 15:22:26 UTC

Verified.

# rpm -q spacewalk-java
spacewalk-java-1.2.39-32.el5sat

Successfully uploaded small binary file according to steps in comment #0.
Also tried case mentioned in comment #1 when I uploaded regular text file (with type "Text File") and then changed it to "Binary File". Passed without problems.

Comment 7 errata-xmlrpc 2010-12-16 15:45:15 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0991.html

Comment 8 Jaromir Hradilek 2010-12-16 16:34:58 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Although RHN Satellite allows a user to upload binary configuration files, an error in a previous update caused this feature not to work. With this update, this error has been fixed, and uploading binary files no longer fails.

Comment 9 Tomas Lestach 2011-01-04 17:48:59 UTC

*** Bug 664680 has been marked as a duplicate of this bug. ***