Bug 652368
| Summary: | whaawmp-0.2.12.1-4.fc14 crashes on startup (bad interaction with PyCObject deprecation and pygtk2) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zoltan Hoppar <hopparz> | ||||
| Component: | whaawmp | Assignee: | Christoph Wickert <christoph.wickert> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 14 | CC: | adrinilbasak, bugs0, christoph.wickert, dmalcolm, j75080, kevin, rrcastaway, samuelyogi, tomspur, wjbealer | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | i686 | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | abrt_hash:720ac66fcffad4fb1e41e24ba3ebbefe6b328597 | ||||||
| Fixed In Version: | whaawmp-0.2.12.1-5.fc14 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-08 21:29:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 620842 | ||||||
| Attachments: |
|
||||||
|
Description
Zoltan Hoppar
2010-11-11 18:07:21 UTC
Created attachment 459813 [details]
File: backtrace
This looks like a gtk or a python bug to me:
#3 0x00416e18 in __assert_fail (assertion=0x784b188 "value", file=0x784d124 "/builddir/build/BUILD/Python-2.7/Objects/dictobject.c", line=759, function=0x784d5a1 "PyDict_SetItem") at assert.c:81
buf = 0x9eaa380 "python: /builddir/build/BUILD/Python-2.7/Objects/dictobject.c:759: PyDict_SetItem: Assertion `value' failed.\n"
#4 0x077933eb in PyDict_SetItem (op=0x9cc546c, key=0x9c98840, value=0x0) at /usr/src/debug/Python-2.7/Objects/dictobject.c:759
mp = <value optimized out>
hash = <value optimized out>
n_used = <value optimized out>
__PRETTY_FUNCTION__ = "PyDict_SetItem"
#5 0x07794ba0 in PyDict_SetItemString (v=0x9cc546c, key=0xc905d2 "_PyGtk_API", item=0x0) at /usr/src/debug/Python-2.7/Objects/dictobject.c:2406
kv = 0x9c98840
err = <value optimized out>
#6 0x00b54d6c in init_gtk () at gtkmodule.c:230
David, what do you think?
Does whaamp run with non-standard warnings settings? This looks like a symptom of the PyCObject deprecation in 2.7; my guess is that whaamp (or something it imports) is overriding warnings before importing GTK: https://fedoraproject.org/wiki/Features/Python_2.7#Caveat:_PyCObject_and_warnings pygtk2 exhibits this crash with an "import gtk" in such a context; see bug 621887. There was some upstream debate about removing the deprecation warning, though IIRC it stalled. Perhaps it's time to do it downstream (and prod upstream). *** Bug 657615 has been marked as a duplicate of this bug. *** ok, where do we go from here? We need to patch whaamp to not override warnings before importing gtk? Package: whaawmp-0.2.12.1-4.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.Right-click 'open with' app 2.Immediate crash 3.Did not reproduce, uninstalled Package: whaawmp-0.2.12.1-4.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Tried to open player from Main Menu 2. 3. Package: whaawmp-0.2.12.1-4.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.as I opened the program it crashed 2. 3. Package: whaawmp-0.2.12.1-4.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Tried toplay avi 2. 3. Package: whaawmp-0.2.12.1-4.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.as I opened the program it crashed 2. 3. The issue here appears to be the call to:
warnings.filterwarnings('error', module='gtk')
within:
/usr/lib/python2.7/site-packages/whaawmp/gui/__init__.py
which turns the PendingDeprecationWarning within gtk into an exception, which gtk assumes can't happen.
I'll try to cook up a patch; adding:
warnings.simplefilter('ignore', PendingDeprecationWarning)
immediately after that line seems to fix the crash.
I've committed/pushed a fix for this into "master" Building whaawmp-0.2.12.1-5.fc15 for dist-rawhide Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2694349 whaawmp-0.2.12.1-5.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/whaawmp-0.2.12.1-5.fc14 I have grabbed this fresh noarch rpm and installed on my x86-64 fedora 14, and for tha first run, didn't wanted to do anything but after with a quick restart everything works perfectly - movies, songs, and more. THX! After installing this rpm and starting whaawmp, I have found whaawmp works excellent on my 32-bit Fedora 14. Many thanks for your effort. whaawmp-0.2.12.1-5.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update whaawmp'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/whaawmp-0.2.12.1-5.fc14 Package: whaawmp-0.2.12.1-4.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.after installing click run. 2. 3. I do not know. Comment ----- whaawmp-0.2.12.1-5.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |