Bug 652368 - whaawmp-0.2.12.1-4.fc14 crashes on startup (bad interaction with PyCObject deprecation and pygtk2)
Summary: whaawmp-0.2.12.1-4.fc14 crashes on startup (bad interaction with PyCObject de...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: whaawmp
Version: 14
Hardware: i686
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:720ac66fcffad4fb1e41e24ba3e...
: 657615 (view as bug list)
Depends On:
Blocks: PyCObject
TreeView+ depends on / blocked
 
Reported: 2010-11-11 18:07 UTC by Zoltan Hoppar
Modified: 2011-01-08 21:29 UTC (History)
10 users (show)

Fixed In Version: whaawmp-0.2.12.1-5.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-08 21:29:31 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (31.83 KB, text/plain)
2010-11-11 18:07 UTC, Zoltan Hoppar
no flags Details

Description Zoltan Hoppar 2010-11-11 18:07:21 UTC
abrt version: 1.1.13
architecture: i686
Attached file: backtrace
cmdline: python /usr/lib/python2.7/site-packages/whaawmp/whaawmp.py
component: whaawmp
crash_function: raise
executable: /usr/bin/python
kernel: 2.6.35.6-48.fc14.i686
package: whaawmp-0.2.12.1-4.fc14
rating: 4
reason: Process /usr/bin/python was killed by signal 6 (SIGABRT)
release: Fedora release 14 (Laughlin)
time: 1289498710
uid: 500

How to reproduce
-----
1. Install the player
2. Try to start
3. Itt will crash immediatelly, so the prog/package is completely useless

Comment 1 Zoltan Hoppar 2010-11-11 18:07:25 UTC
Created attachment 459813 [details]
File: backtrace

Comment 2 Thomas Spura 2010-11-12 14:11:50 UTC
This looks like a gtk or a python bug to me:
#3  0x00416e18 in __assert_fail (assertion=0x784b188 "value", file=0x784d124 "/builddir/build/BUILD/Python-2.7/Objects/dictobject.c", line=759, function=0x784d5a1 "PyDict_SetItem") at assert.c:81
        buf = 0x9eaa380 "python: /builddir/build/BUILD/Python-2.7/Objects/dictobject.c:759: PyDict_SetItem: Assertion `value' failed.\n"
#4  0x077933eb in PyDict_SetItem (op=0x9cc546c, key=0x9c98840, value=0x0) at /usr/src/debug/Python-2.7/Objects/dictobject.c:759
        mp = <value optimized out>
        hash = <value optimized out>
        n_used = <value optimized out>
        __PRETTY_FUNCTION__ = "PyDict_SetItem"
#5  0x07794ba0 in PyDict_SetItemString (v=0x9cc546c, key=0xc905d2 "_PyGtk_API", item=0x0) at /usr/src/debug/Python-2.7/Objects/dictobject.c:2406
        kv = 0x9c98840
        err = <value optimized out>
#6  0x00b54d6c in init_gtk () at gtkmodule.c:230

David, what do you think?

Comment 3 Dave Malcolm 2010-11-12 16:09:16 UTC
Does whaamp run with non-standard warnings settings?

This looks like a symptom of the PyCObject deprecation in 2.7; my guess is that whaamp (or something it imports) is overriding warnings before importing GTK:
https://fedoraproject.org/wiki/Features/Python_2.7#Caveat:_PyCObject_and_warnings

pygtk2 exhibits this crash with an "import gtk" in such a context; see bug 621887.

There was some upstream debate about removing the deprecation warning, though IIRC it stalled.  Perhaps it's time to do it downstream (and prod upstream).

Comment 4 Kevin Fenzi 2010-12-13 18:04:50 UTC
*** Bug 657615 has been marked as a duplicate of this bug. ***

Comment 5 Kevin Fenzi 2010-12-13 18:10:07 UTC
ok, where do we go from here? 

We need to patch whaamp to not override warnings before importing gtk?

Comment 6 bugs0 2010-12-15 01:02:55 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1.Right-click 'open with' app
2.Immediate crash
3.Did not reproduce, uninstalled

Comment 7 Wayne Jonas Bealer 2010-12-18 19:30:02 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1.  Tried to open player from Main Menu
2.
3.

Comment 8 Bob 2010-12-28 15:44:46 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1.as I opened the program it crashed
2.
3.

Comment 9 Zoltan Hoppar 2010-12-30 05:10:54 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1. Tried toplay avi
2.
3.

Comment 10 Bob 2010-12-30 11:57:29 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: i686
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1.as I opened the program it crashed
2.
3.

Comment 11 Dave Malcolm 2010-12-30 18:14:41 UTC
The issue here appears to be the call to:
  warnings.filterwarnings('error', module='gtk')
within:
  /usr/lib/python2.7/site-packages/whaawmp/gui/__init__.py
which turns the PendingDeprecationWarning within gtk into an exception, which gtk assumes can't happen.

I'll try to cook up a patch; adding:
   warnings.simplefilter('ignore', PendingDeprecationWarning)
immediately after that line seems to fix the crash.

Comment 12 Dave Malcolm 2010-12-30 18:25:17 UTC
I've committed/pushed a fix for this into "master"
  Building whaawmp-0.2.12.1-5.fc15 for dist-rawhide
  Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2694349

Comment 13 Fedora Update System 2010-12-31 03:30:28 UTC
whaawmp-0.2.12.1-5.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/whaawmp-0.2.12.1-5.fc14

Comment 14 Zoltan Hoppar 2010-12-31 09:17:52 UTC
I have grabbed this fresh noarch rpm and installed on my x86-64 fedora 14, and for tha first run, didn't wanted to do anything but after with a quick restart everything works perfectly - movies, songs, and more. THX!

Comment 15 John B Davis Jr 2010-12-31 18:00:49 UTC
After installing this rpm and starting whaawmp, I have found whaawmp works excellent on my 32-bit Fedora 14.  Many thanks for your effort.

Comment 16 Fedora Update System 2010-12-31 20:57:49 UTC
whaawmp-0.2.12.1-5.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update whaawmp'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/whaawmp-0.2.12.1-5.fc14

Comment 17 bidyut basak 2011-01-02 19:31:34 UTC
Package: whaawmp-0.2.12.1-4.fc14
Architecture: x86_64
OS Release: Fedora release 14 (Laughlin)


How to reproduce
-----
1.after installing click run.
2.
3.
I do not know.

Comment
-----

Comment 18 Fedora Update System 2011-01-08 21:29:26 UTC
whaawmp-0.2.12.1-5.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.