Bug 659895 (makedepf90)
| Summary: | Review Request: makedepf90 - Create Makefile dependency list for Fortran source files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Susi Lehtola <susi.lehtola> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, susi.lehtola |
| Target Milestone: | --- | Flags: | susi.lehtola:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | makedepf90-2.8.8-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-12 00:02:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 659896 | ||
|
Description
Dominik 'Rathann' Mierzejewski
2010-12-04 00:39:17 UTC
rpmlint output:
makedepf90.src: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.src: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
makedepf90.x86_64: W: spelling-error %description -l en_US cpp -> cop, cp, pp
makedepf90.x86_64: W: spelling-error %description -l en_US gcc -> cc, acc, g cc
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
- IMHO using macros for rm and make is a bit silly, but it's not disallowed.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
514a32147e956264ac5e60cc12fd5f5d makedepf90-2.8.8.tar.gz
514a32147e956264ac5e60cc12fd5f5d ../SOURCES/makedepf90-2.8.8.tar.gz
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. ~OK
- Please add INSTALL="install -p" to make install so that time stamp of the man page is preserved.
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package that owns the directory. N/A
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
Package APPROVED. Please check the time stamp issue before importing to git.
Excellent! Thanks for the speedy review. I'll fix the timestamp issue on import. New Package SCM Request ======================= Package Name: makedepf90 Short Description: Create Makefile dependency list for Fortran source files Owners: rathann Branches: f13 f14 el6 InitialCC: If you want to return the favor, please see bug #661143 and bug #661154 , both quite simple packages. Git done (by process-git-requests). makedepf90-2.8.8-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc14 makedepf90-2.8.8-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc13 makedepf90-2.8.8-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update makedepf90'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/makedepf90-2.8.8-1.fc14 makedepf90-2.8.8-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. makedepf90-2.8.8-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ======================= Package Name: makedepf90 New Branches: el5 Owners: rathann Git done (by process-git-requests). |