Spec URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec SRPM URL: http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-1.fc14.src.rpm Upstream URL: http://www.votca.org Description: Versatile Object-oriented Toolkit for Coarse-graining Applications (VOTCA) is a package intended to reduce the amount of routine work when doing systematic coarse-graining of various systems. The core is written in C++. rpmlint output: votca-csg.src: W: spelling-error Summary(en_US) graining -> gaining, raining, training votca-csg.src: W: spelling-error %description -l en_US graining -> gaining, raining, training votca-csg.src: W: invalid-url Source0: http://votca.googlecode.com/files/votca-csg-1.0.1.tar.gz HTTP Error 404: Not Found votca-csg.x86_64: W: spelling-error Summary(en_US) graining -> gaining, raining, training votca-csg.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training votca-csg.x86_64: W: no-manual-page-for-binary multi_g_density votca-csg.x86_64: W: no-manual-page-for-binary csg_dump votca-csg.x86_64: W: no-manual-page-for-binary multi_g_rdf votca-csg.x86_64: W: no-manual-page-for-binary csg_gmxtopol votca-csg.x86_64: W: no-manual-page-for-binary csg_fmatch votca-csg.x86_64: W: no-manual-page-for-binary csg_part_dist votca-csg.x86_64: W: no-manual-page-for-binary csg_map votca-csg.x86_64: W: no-manual-page-for-binary csg_stat votca-csg.x86_64: W: no-manual-page-for-binary csg_property votca-csg.x86_64: W: no-manual-page-for-binary csg_resample votca-csg.x86_64: W: no-manual-page-for-binary csg_boltzmann votca-csg.x86_64: W: no-manual-page-for-binary csg_inverse votca-csg.x86_64: W: no-manual-page-for-binary csg_call votca-csg.x86_64: W: no-manual-page-for-binary csg_imcrepack votca-csg-bash.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training votca-csg-bash.noarch: W: spelling-error %description -l en_US perl -> Perl, peel, perk votca-csg-bash.noarch: W: no-documentation votca-csg-bash.noarch: W: non-conffile-in-etc /etc/bash_completion.d/votca votca-csg-common.noarch: W: spelling-error %description -l en_US graining -> gaining, raining, training votca-csg-common.noarch: W: no-documentation votca-csg-devel.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training votca-csg-devel.x86_64: W: no-documentation votca-csg-libs.x86_64: W: spelling-error Summary(en_US) graining -> gaining, raining, training votca-csg-libs.x86_64: W: spelling-error %description -l en_US graining -> gaining, raining, training 7 packages and 0 specfiles checked; 0 errors, 29 warnings. These are all OK.
*** Bug 659972 has been marked as a duplicate of this bug. ***
Notes from my side: - "coarse-graining" is spelled correctly. - we have man pages in the next release. - there is doxygen documentation through 'make html'
(In reply to comment #2) > Notes from my side: > - "coarse-graining" is spelled correctly. Spellings are made coherent in the next revision. > - there is doxygen documentation through 'make html' Doesn't seem so: Making html in doc make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop.
(In reply to comment #3) > > - there is doxygen documentation through 'make html' > Doesn't seem so: > Making html in doc > make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' > make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' > make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop. Ah, I see. The Doxygen file is missing in the dist tarball, I fixed it for the next release.
Source matches upstream: $ md5sum votca-csg-1.0.1.tar.gz* 855fec6510665d45d81c4987f62b95b2 votca-csg-1.0.1.tar.gz 855fec6510665d45d81c4987f62b95b2 votca-csg-1.0.1.tar.gz.1 Comments: 1. Typo: %package devel ... Requires: votka-tools-devel ./share/template/template.cc is missing licencing information 2. Timestamps are not preserved in make install. Otherwise the package looks fine.
Ahem, it should be: 2 ./share/template/template.cc is missing licencing information. 3. Timestamps are not preserved in make install. of course. :)
(In reply to comment #6) > 2 ./share/template/template.cc is missing licencing information. I added licensing information: <http://code.google.com/p/votca/source/detail?r=99793a446a09f4e2f78bf05cd015fa362a162b70&repo=csg> Should it also be added to the Makefile in ./share/template/ ?
Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release. http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm
(In reply to comment #7) > (In reply to comment #6) > > 2 ./share/template/template.cc is missing licencing information. > I added licensing information: Good, thanks. > Should it also be added to the Makefile in ./share/template/ ? I don't think that's necessary.
(In reply to comment #8) > Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release. > > http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec > http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm Perfect. The packages is now APPROVED.
Thanks a lot for the review! New Package SCM Request ======================= Package Name: votca-csg Short Description: VOTCA coarse-graining engine Owners: jussilehtola Branches: F-13 F-14 InitialCC:
Git done (by process-git-requests).
votca-csg-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14
votca-csg-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13
votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13
votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14
votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update votca-csg votca-tools'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14
votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
votca-csg-1.0.1-2.fc13, votca-tools-1.0.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.