Bug 661154 (votca-csg)
Summary: | Review Request: votca-csg - VOTCA coarse graining engine | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Susi Lehtola <susi.lehtola> |
Component: | Package Review | Assignee: | Dominik 'Rathann' Mierzejewski <dominik> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, junghans, notting |
Target Milestone: | --- | Flags: | dominik:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | votca-csg-1.0.1-2.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-12-25 00:27:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 661143 | ||
Bug Blocks: |
Description
Susi Lehtola
2010-12-07 22:17:51 UTC
*** Bug 659972 has been marked as a duplicate of this bug. *** Notes from my side: - "coarse-graining" is spelled correctly. - we have man pages in the next release. - there is doxygen documentation through 'make html' (In reply to comment #2) > Notes from my side: > - "coarse-graining" is spelled correctly. Spellings are made coherent in the next revision. > - there is doxygen documentation through 'make html' Doesn't seem so: Making html in doc make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop. (In reply to comment #3) > > - there is doxygen documentation through 'make html' > Doesn't seem so: > Making html in doc > make[2]: Entering directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' > make[2]: Leaving directory `/builddir/build/BUILD/votca-csg-1.0.1/share/doc' > make[2]: *** No rule to make target `Doxyfile', needed by `html'. Stop. Ah, I see. The Doxygen file is missing in the dist tarball, I fixed it for the next release. Source matches upstream: $ md5sum votca-csg-1.0.1.tar.gz* 855fec6510665d45d81c4987f62b95b2 votca-csg-1.0.1.tar.gz 855fec6510665d45d81c4987f62b95b2 votca-csg-1.0.1.tar.gz.1 Comments: 1. Typo: %package devel ... Requires: votka-tools-devel ./share/template/template.cc is missing licencing information 2. Timestamps are not preserved in make install. Otherwise the package looks fine. Ahem, it should be: 2 ./share/template/template.cc is missing licencing information. 3. Timestamps are not preserved in make install. of course. :) (In reply to comment #6) > 2 ./share/template/template.cc is missing licencing information. I added licensing information: <http://code.google.com/p/votca/source/detail?r=99793a446a09f4e2f78bf05cd015fa362a162b70&repo=csg> Should it also be added to the Makefile in ./share/template/ ? Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release. http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm (In reply to comment #7) > (In reply to comment #6) > > 2 ./share/template/template.cc is missing licencing information. > I added licensing information: Good, thanks. > Should it also be added to the Makefile in ./share/template/ ? I don't think that's necessary. (In reply to comment #8) > Fixed 1 and 3. 2 will be fixed when upstream (Christoph) makes a new release. > > http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg.spec > http://theory.physics.helsinki.fi/~jzlehtol/rpms/votca-csg-1.0.1-2.fc14.src.rpm Perfect. The packages is now APPROVED. Thanks a lot for the review! New Package SCM Request ======================= Package Name: votca-csg Short Description: VOTCA coarse-graining engine Owners: jussilehtola Branches: F-13 F-14 InitialCC: Git done (by process-git-requests). votca-csg-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14 votca-csg-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13 votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc13,votca-tools-1.0.1-2.fc13 votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update votca-csg votca-tools'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/votca-csg-1.0.1-2.fc14,votca-tools-1.0.1-2.fc14 votca-csg-1.0.1-2.fc14, votca-tools-1.0.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. votca-csg-1.0.1-2.fc13, votca-tools-1.0.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |