Bug 666865
| Summary: | Firefox/Flash freezes on right button click | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Stransky <stransky> |
| Component: | nspluginwrapper | Assignee: | Martin Stransky <stransky> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | atodorov, brackbillbruce, caillon, davidben, eddie, horsley1953, jedgecombe, rob2098, stransky, udovdh |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nspluginwrapper-1.3.2-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 662203 | Environment: | |
| Last Closed: | 2011-05-10 03:31:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 662203 | ||
| Bug Blocks: | |||
|
Description
Martin Stransky
2011-01-03 14:27:49 UTC
*** Bug 607884 has been marked as a duplicate of this bug. *** Why is this bug the same as 607884? I didn't click on a flash thing at all... Can you explain? Whatever way: please fix the issue as gnash (an alternative) eats way too much cpu. Severity needs to be higher: The reference flash implementation doesn't work anymore. The alternatives have shortcomings.... The nspluginwrapper issue has been roaring it's head for a while longer than the start date of this bug. (please do google) Flash is an important part of web content... Can we help to get this fixed? This is a serious problem. flash from adobe with the wrapper worked soso, but now it doesn't work at all; gnash eats cpu and doesn't work in all cases so what else can we do? The gtk_main() from nspluginwrapper has to be replaced by something what won't block the event loop when g_main_loop_run() is launched fem flash plugin with the same context. Mozilla uses it's own message loop which does not block so it may be a solution for nspluginwrapper too. Thanks for the info. Who will make the necessary changes? What is being done? We aren't even answered what we can do. Our flash isn't working without a decent workaround! udo, From your comment to Bug 607884 (and here), I think you are experiencing a different bug. Bug 607884, this bug, and its duplicates look to be all flash "right click" related bugs and setting "dom.ipc.plugins.enabled=true" in about:config appears to be an effective workaround. Taken from your previous comment to Bug 607884, I did a search for: "pk-gtk-module flash" (without the quotes) and it returned many bug reports and message board posts that look to be more related to your bug. Such as http://forum.nginx.org/read.php?30,137977 http://fedoraproject.org/wiki/Flash#After_Fedora_upgrade.2Fpreupgrade and many others. I hope this helps. Bruce, Thanks for the research. So I removed gnash-plugin, reinstalled flash-plugin and nspluginwrapper. about:plugins showed the intended situation. I get: (npviewer.bin:4438): Gtk-WARNING **: Unable to locate theme engine in module_path: "clearlooks", *** NSPlugin Wrapper *** WARNING:(../src/npw-wrapper.c:1858):invoke_NPP_Destroy: assertion failed: (rpc_method_invoke_possible(plugin->connection)) *** NSPlugin Wrapper *** ERROR: NPP_Write() wait for reply: Message timeout *** NSPlugin Wrapper *** WARNING:(../src/npw-wrapper.c:2239):invoke_NPP_DestroyStream: assertion failed: (rpc_method_invoke_possible(plugin->connection)) And a grey youtube screen. Or are the cookies we disabled for gnash so important for adobe's flash? Without nspluginwrapper everything works fine here. *** Bug 658225 has been marked as a duplicate of this bug. *** The hang isn't related to main loops or anything. Flash (or maybe even GTK) is requesting a grab that is supposed to succeed and doesn't. It then gets confused. The thing that makes the youtube video different from the page in question is that the page uses a windowed plugin which causes events to be plumbed to the plugin differently. The failed grab is caused by a combination of an nspluginwrapper bug (if you could call it that) and how X11 input grabs work that makes out-of-process plugins difficult. Arguably NPAPI should have provided a hook for the plugin to request the grab from the browser, but no one would have used it anyway (as it would preclude you from opening the menu with GTK). See this patch. https://github.com/davidben/nspluginwrapper/commit/662820f46b8c37b938cc1dc71f5ab76bac750c21 The fix is somewhat of a hack (the point of doing the passive -> active grab thing is to avoid some UI race conditions), but I'm not sure a better solution is possible in the X protocol. This is also what Firefox does. > that the page uses a windowed plugin
Sorry, the page uses a windowless plugin. A windowed plugin bypasses the browser and gives the passive grab straight to the Flash plugin and everything just works.
nspluginwrapper-1.3.2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nspluginwrapper-1.3.2-1.fc15 Package nspluginwrapper-1.3.2-1.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nspluginwrapper-1.3.2-1.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/nspluginwrapper-1.3.2-1.fc15 then log in and leave karma (feedback). nspluginwrapper-1.3.2-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. nspluginwrapper-1.3.2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nspluginwrapper-1.3.2-1.fc14 nspluginwrapper-1.3.2-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/nspluginwrapper-1.3.2-1.fc13 nspluginwrapper-1.3.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. nspluginwrapper-1.3.2-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |