Bug 667143

Summary: Reposync crashes after file not found
Product: Red Hat Satellite 5 Reporter: Šimon Lukašík <slukasik>
Component: ServerAssignee: Michael Mráka <mmraka>
Status: CLOSED ERRATA QA Contact: Dimitar Yordanov <dyordano>
Severity: medium Docs Contact:
Priority: low    
Version: 540CC: cperry, dyordano, jhutar, mminar, mmraka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spacewalk-backend-1.2.13-57 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-21 09:44:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 715348    
Attachments:
Description Flags
snip of the rhn_taskomatic_daemon.log none

Description Šimon Lukašík 2011-01-04 15:58:54 UTC 
Description of problem:
If the package described in repodata is deleted from repository 
during the repo-sync, process of reposync will fail.

Version-Release number of selected component (if applicable):
spacewalk-backend-tools-1.2.13-20.el5sat

How reproducible:
1 of 1

Steps to Reproduce:
1. Start a sync of a repository
2. Delete the package from the rerpository
3.
  
Actual results:
Reposync crashes with no such file exception

Expected results:
Reposync should skip the package and sync the rest of the
repo. Or at least notify the system administrator


Additional info:
Comment 1 Šimon Lukašík 2011-01-04 16:00:27 UTC 
Created attachment 471688 [details]
snip of the rhn_taskomatic_daemon.log
Comment 2 Šimon Lukašík 2011-01-04 16:02:04 UTC 
QA can use global [beaker-tasks] repository, which is pretty much unstable.
Comment 3 Michael Mráka 2011-03-03 15:26:49 UTC 
It's been fixed some time ago by commits
d09d119267834048004b2aecc98ec1adba91edf4
16dbafff04c457cef2e0327cb8ee0adbfe816df8

Package spacewalk-backend-1.4.16-1 works as expected.
Comment 4 Michael Mráka 2011-03-03 15:28:28 UTC 
(In reply to comment #3)
> It's been fixed some time ago by commits
> d09d119267834048004b2aecc98ec1adba91edf4
> 16dbafff04c457cef2e0327cb8ee0adbfe816df8
> 
> Package spacewalk-backend-1.4.16-1 works as expected.

This is a fix in upstream not in satellite.
Comment 5 Šimon Lukašík 2011-08-03 12:47:41 UTC 
*** Bug 727840 has been marked as a duplicate of this bug. ***
Comment 6 Michael Mráka 2011-10-26 08:59:19 UTC 
Backported to SATELLITE-5.4 as
commit 1cf37a27b2afa909852fd88a361a44aeb69e6e00
    moved checksum logic into ContentPackage
    yum repo metadata have precomputed checksum we can use to compare the
    package on disk; unfortunately it's a different from the one we want to
    store so we have to compute the second one on our own
commit 97ec057ce6487efc98f3b9557b738a2d7dcb777f
    spacewalk-repo-sync should not download package which is already on disk
Comment 8 Michael Mráka 2011-10-27 07:46:07 UTC 
One more backported commit
commit 09df8004b27a1658d366fda96cf5ed339e42fa0b
    shortened and narrowed package sync logic
    process packages in one loop
    (cherry picked from commit ab07eddd4caf3de6a04c7e35ae9217eda101bffa)
Comment 11 Šimon Lukašík 2011-11-11 15:02:20 UTC 
Given the bug 753158 comment 0, which says it's 100% reproducible -->
isn't this bug supposed to be FailedQA?
Comment 12 errata-xmlrpc 2011-11-21 09:44:49 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1466.html