Bug 678924
Summary: | Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | iarnell:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Math-Random-ISAAC-XS-1.004-2.fc15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-04-25 02:40:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 678925 | ||
Bug Blocks: |
Description
Emmanuel Seyman
2011-02-20 21:30:09 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2906368 You should BuildRequire: perl(Test::LeakTrace) to enable t/03memory.t You should package Test::Valgrind and submit for review (not a blocker). You need to strip the carriage returns from the example scripts. rpmlint is confused by "MIT or GPL+ or Artistic" but the license is correct and valid. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2906368 Spec looks sane, clean and consistent; license is correct (MIT or GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz 3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz.srpm Final provides / requires are sane: ======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.src.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS.src: W: invalid-license Artistic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides ====> requires perl(ExtUtils::CBuilder) perl(ExtUtils::ParseXS) perl(Math::Random::ISAAC) perl(Module::Build) perl(Test::More) perl(Test::NoWarnings) ====> obsoletes ====> conflicts ======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS.x86_64: W: invalid-license Artistic perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/benchmark.pl perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/distribution.pl 1 packages and 0 specfiles checked; 2 errors, 1 warnings. ====> provides perl(Math::Random::ISAAC::XS) = 1.004 perl-Math-Random-ISAAC-XS = 1.004-1.fc16 perl-Math-Random-ISAAC-XS(x86-64) = 1.004-1.fc16 ====> requires libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl(Math::Random::ISAAC) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(warnings) perl(XSLoader) rtld(GNU_HASH) ====> obsoletes ====> conflicts ======> perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS-debuginfo.x86_64: W: invalid-license Artistic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl-Math-Random-ISAAC-XS-debuginfo = 1.004-1.fc16 perl-Math-Random-ISAAC-XS-debuginfo(x86-64) = 1.004-1.fc16 ====> requires ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.9 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.9 INFO: Mock Version: 1.1.9 State Changed: lock buildroot INFO: installing package(s): perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Math-Random-ISAAC-XS x86_64 1.004-1.fc16 /perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64 80 k perl-Math-Random-ISAAC-XS-debuginfo x86_64 1.004-1.fc16 /perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64 73 k Installing for dependencies: perl-Math-Random-ISAAC noarch 1.004-2.fc16 fedora 36 k Transaction Summary ================================================================================ Install 3 Package(s) Total size: 188 k Installed size: 235 k Installed: perl-Math-Random-ISAAC-XS.x86_64 0:1.004-1.fc16 perl-Math-Random-ISAAC-XS-debuginfo.x86_64 0:1.004-1.fc16 Dependency Installed: perl-Math-Random-ISAAC.noarch 0:1.004-2.fc16 State Changed: unlock buildroot (In reply to comment #2) > > You should BuildRequire: perl(Test::LeakTrace) to enable t/03memory.t Done > You need to strip the carriage returns from the example scripts. Done. Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS-1.004-2.fc14.src.rpm Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2907406 APPROVED. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2907406 Spec looks sane, clean and consistent; license is correct (MIT or GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz 3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz.srpm Final provides / requires are sane: ======> perl-Math-Random-ISAAC-XS-1.004-2.fc16.src.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS.src: W: invalid-license Artistic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides ====> requires perl(ExtUtils::CBuilder) perl(ExtUtils::ParseXS) perl(Math::Random::ISAAC) perl(Module::Build) perl(Test::LeakTrace) perl(Test::More) perl(Test::NoWarnings) ====> obsoletes ====> conflicts ======> perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS.x86_64: W: invalid-license Artistic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl(Math::Random::ISAAC::XS) = 1.004 perl-Math-Random-ISAAC-XS = 1.004-2.fc16 perl-Math-Random-ISAAC-XS(x86-64) = 1.004-2.fc16 ====> requires libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl(Math::Random::ISAAC) perl(:MODULE_COMPAT_5.12.3) perl(strict) perl(warnings) perl(XSLoader) rtld(GNU_HASH) ====> obsoletes ====> conflicts ======> perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64.rpm <====== ====> rpmlint perl-Math-Random-ISAAC-XS-debuginfo.x86_64: W: invalid-license Artistic 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl-Math-Random-ISAAC-XS-debuginfo = 1.004-2.fc16 perl-Math-Random-ISAAC-XS-debuginfo(x86-64) = 1.004-2.fc16 ====> requires ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.9 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.9 INFO: Mock Version: 1.1.9 State Changed: lock buildroot INFO: installing package(s): perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64.rpm perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Math-Random-ISAAC-XS x86_64 1.004-2.fc16 /perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64 79 k perl-Math-Random-ISAAC-XS-debuginfo x86_64 1.004-2.fc16 /perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64 73 k Installing for dependencies: perl-Math-Random-ISAAC noarch 1.004-2.fc16 fedora 36 k Transaction Summary ================================================================================ Install 3 Package(s) Total size: 188 k Installed size: 234 k Installed: perl-Math-Random-ISAAC-XS.x86_64 0:1.004-2.fc16 perl-Math-Random-ISAAC-XS-debuginfo.x86_64 0:1.004-2.fc16 Dependency Installed: perl-Math-Random-ISAAC.noarch 0:1.004-2.fc16 State Changed: unlock buildroot New Package SCM Request ======================= Package Name: perl-Math-Random-ISAAC-XS Short Description: C implementation of the ISAAC PRNG algorithm Owners: eseyman Branches: f14 f15 InitialCC: perl-sig Git done (by process-git-requests). perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Math-Random-ISAAC-XS-1.004-2.fc15 perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been pushed to the Fedora 15 testing repository. perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been pushed to the Fedora 15 stable repository. |