Bug 678924 - Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRNG algorithm
Summary: Review Request: perl-Math-Random-ISAAC-XS - C implementation of the ISAAC PRN...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 678925
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-20 21:30 UTC by Emmanuel Seyman
Modified: 2011-04-25 02:40 UTC (History)
2 users (show)

Fixed In Version: perl-Math-Random-ISAAC-XS-1.004-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-04-25 02:40:20 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2011-02-20 21:30:09 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS-1.004-1.fc14.src.rpm
Description:
This module implements the same interface as Math::Random::ISAAC in C and can
be used as a drop-in replacement. This is the recommended implementation of the
module, based on Bob Jenkins' reference implementation in C.

Comment 1 Iain Arnell 2011-03-12 09:49:42 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2906368

Comment 2 Iain Arnell 2011-03-12 10:02:56 UTC
You should BuildRequire: perl(Test::LeakTrace) to enable t/03memory.t
You should package Test::Valgrind and submit for review (not a blocker).
You need to strip the carriage returns from the example scripts.

rpmlint is confused by "MIT or GPL+ or Artistic" but the license is correct and
valid.



koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2906368

Spec looks sane, clean and consistent; license is correct (MIT or GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz.srpm

Final provides / requires are sane:

======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.src.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.src: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(ExtUtils::CBuilder)  
perl(ExtUtils::ParseXS)  
perl(Math::Random::ISAAC)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::NoWarnings)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.x86_64: W: invalid-license Artistic
perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/benchmark.pl
perl-Math-Random-ISAAC-XS.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-XS-1.004/examples/distribution.pl
1 packages and 0 specfiles checked; 2 errors, 1 warnings.
====> provides
perl(Math::Random::ISAAC::XS) = 1.004
perl-Math-Random-ISAAC-XS = 1.004-1.fc16
perl-Math-Random-ISAAC-XS(x86-64) = 1.004-1.fc16
====> requires
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(Math::Random::ISAAC)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(warnings)  
perl(XSLoader)  
rtld(GNU_HASH)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS-debuginfo.x86_64: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl-Math-Random-ISAAC-XS-debuginfo = 1.004-1.fc16
perl-Math-Random-ISAAC-XS-debuginfo(x86-64) = 1.004-1.fc16
====> requires
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64.rpm perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64.rpm
INFO: 
================================================================================
 Package                             Arch   Version      Repository        Size
================================================================================
Installing:
 perl-Math-Random-ISAAC-XS           x86_64 1.004-1.fc16 /perl-Math-Random-ISAAC-XS-1.004-1.fc16.x86_64
                                                                           80 k
 perl-Math-Random-ISAAC-XS-debuginfo x86_64 1.004-1.fc16 /perl-Math-Random-ISAAC-XS-debuginfo-1.004-1.fc16.x86_64
                                                                           73 k
Installing for dependencies:
 perl-Math-Random-ISAAC              noarch 1.004-2.fc16 fedora            36 k

Transaction Summary
================================================================================
Install       3 Package(s)

Total size: 188 k
Installed size: 235 k

Installed:
  perl-Math-Random-ISAAC-XS.x86_64 0:1.004-1.fc16                               
  perl-Math-Random-ISAAC-XS-debuginfo.x86_64 0:1.004-1.fc16                     

Dependency Installed:
  perl-Math-Random-ISAAC.noarch 0:1.004-2.fc16                                  


State Changed: unlock buildroot

Comment 3 Emmanuel Seyman 2011-03-12 20:08:26 UTC
(In reply to comment #2)
>
> You should BuildRequire: perl(Test::LeakTrace) to enable t/03memory.t

Done

> You need to strip the carriage returns from the example scripts.

Done.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC-XS/perl-Math-Random-ISAAC-XS-1.004-2.fc14.src.rpm

Comment 4 Iain Arnell 2011-03-12 23:43:11 UTC
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2907406

Comment 5 Iain Arnell 2011-03-13 06:54:12 UTC
APPROVED.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2907406

Spec looks sane, clean and consistent; license is correct (MIT or GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz
3a05d7b32556b9f140ad83621d04b4648fe2dff4 Math-Random-ISAAC-XS-1.004.tar.gz.srpm

Final provides / requires are sane:

======> perl-Math-Random-ISAAC-XS-1.004-2.fc16.src.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.src: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(ExtUtils::CBuilder)  
perl(ExtUtils::ParseXS)  
perl(Math::Random::ISAAC)  
perl(Module::Build)  
perl(Test::LeakTrace)  
perl(Test::More)  
perl(Test::NoWarnings)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS.x86_64: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(Math::Random::ISAAC::XS) = 1.004
perl-Math-Random-ISAAC-XS = 1.004-2.fc16
perl-Math-Random-ISAAC-XS(x86-64) = 1.004-2.fc16
====> requires
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(Math::Random::ISAAC)  
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(warnings)  
perl(XSLoader)  
rtld(GNU_HASH)  
====> obsoletes
====> conflicts

======> perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64.rpm <======
====> rpmlint
perl-Math-Random-ISAAC-XS-debuginfo.x86_64: W: invalid-license Artistic
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl-Math-Random-ISAAC-XS-debuginfo = 1.004-2.fc16
perl-Math-Random-ISAAC-XS-debuginfo(x86-64) = 1.004-2.fc16
====> requires
====> obsoletes
====> conflicts


====> mock install
INFO: mock.py version 1.1.9 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.9
INFO: Mock Version: 1.1.9
State Changed: lock buildroot
INFO: installing package(s): perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64.rpm perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64.rpm
INFO: 
================================================================================
 Package                             Arch   Version      Repository        Size
================================================================================
Installing:
 perl-Math-Random-ISAAC-XS           x86_64 1.004-2.fc16 /perl-Math-Random-ISAAC-XS-1.004-2.fc16.x86_64
                                                                           79 k
 perl-Math-Random-ISAAC-XS-debuginfo x86_64 1.004-2.fc16 /perl-Math-Random-ISAAC-XS-debuginfo-1.004-2.fc16.x86_64
                                                                           73 k
Installing for dependencies:
 perl-Math-Random-ISAAC              noarch 1.004-2.fc16 fedora            36 k

Transaction Summary
================================================================================
Install       3 Package(s)

Total size: 188 k
Installed size: 234 k

Installed:
  perl-Math-Random-ISAAC-XS.x86_64 0:1.004-2.fc16                               
  perl-Math-Random-ISAAC-XS-debuginfo.x86_64 0:1.004-2.fc16                     

Dependency Installed:
  perl-Math-Random-ISAAC.noarch 0:1.004-2.fc16                                  


State Changed: unlock buildroot

Comment 6 Emmanuel Seyman 2011-03-22 08:48:43 UTC
New Package SCM Request
=======================
Package Name: perl-Math-Random-ISAAC-XS
Short Description: C implementation of the ISAAC PRNG algorithm
Owners: eseyman
Branches: f14 f15
InitialCC: perl-sig

Comment 7 Jason Tibbitts 2011-03-22 13:56:08 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2011-04-20 22:28:19 UTC
perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Math-Random-ISAAC-XS-1.004-2.fc15

Comment 9 Fedora Update System 2011-04-21 02:59:28 UTC
perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been pushed to the Fedora 15 testing repository.

Comment 10 Fedora Update System 2011-04-25 02:40:14 UTC
perl-Math-Random-ISAAC-XS-1.004-2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.