Bug 678925 - Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG algorithm
Summary: Review Request: perl-Math-Random-ISAAC - Perl interface to the ISAAC PRNG alg...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 678924 678931
TreeView+ depends on / blocked
 
Reported: 2011-02-20 21:34 UTC by Emmanuel Seyman
Modified: 2015-04-17 18:15 UTC (History)
4 users (show)

Fixed In Version: perl-Math-Random-ISAAC-1.004-13.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-05 02:38:40 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2011-02-20 21:34:11 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC/perl-Math-Random-ISAAC.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-ISAAC/perl-Math-Random-ISAAC-1.004-1.fc14.src.rpm
Description:
As with other Pseudo-Random Number Generator (PRNG) algorithms like the
Mersenne Twister (see Math::Random::MT), this algorithm is designed to take
some seed information and produce seemingly random results as output.

Comment 1 Iain Arnell 2011-02-24 04:27:36 UTC
+ source files match upstream.  
    46110b9a7bb96fe641bdfaf35bdafec5  Math-Random-ISAAC-1.004.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
    MIT or GPL+ or Artistic

+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2862720

+ package installs properly.
- rpmlint has complaints:
    perl-Math-Random-ISAAC.noarch: W: invalid-license Artistic
    perl-Math-Random-ISAAC.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-1.004/examples/benchmark.pl
    perl-Math-Random-ISAAC.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/perl-Math-Random-ISAAC-1.004/examples/distribution.pl
    perl-Math-Random-ISAAC.src: W: invalid-license Artistic
    2 packages and 0 specfiles checked; 2 errors, 2 warnings.

+ final provides and requires are sane:
    perl(Math::Random::ISAAC) = 1.004
    perl(Math::Random::ISAAC::PP) = 1.004
    perl-Math-Random-ISAAC = 1.004-1.fc16
=
    perl(Carp)  
    perl(integer)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  
    perl(warnings)  

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
    t/01compile.t .............. ok
    t/02sequence.t ............. ok
    t/03memory.t ............... ok
    t/04uniform.t .............. skipped: Author tests not required for installation
    t/05fallback.t ............. skipped: Test::Without::Module and Math::Random::ISAAC::XS required to test fallback ability
    t/06exceptions.t ........... ok
    t/release-dist-manifest.t .. skipped: these tests are for release candidate testing
    t/release-kwalitee.t ....... skipped: these tests are for release candidate testing
    t/release-pod-coverage.t ... skipped: these tests are for release candidate testing
    t/release-pod-syntax.t ..... skipped: these tests are for release candidate testing
    t/release-portability.t .... skipped: these tests are for release candidate testing
    All tests successful.
    Files=11, Tests=609,  1 wallclock secs ( 0.08 usr  0.02 sys +  0.27 cusr  0.03 csys =  0.40 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


Looks like rpmlint gets confused with "MIT or GPL+ or Artistic", but can be ignored - the license is good.

The wrong-script-end-of-line-encoding should be fixed in %prep: sed -i 's/\r//' examples/*.pl

APPROVED with that one minor tweak.

Comment 2 Emmanuel Seyman 2011-02-25 09:58:10 UTC
(In reply to comment #1)
>
> The wrong-script-end-of-line-encoding should be fixed in %prep: sed -i 's/\r//' examples/*.pl

Fixed.

> APPROVED with that one minor tweak.

Thanks, Ian!

New Package SCM Request
=======================
Package Name: perl-Math-Random-ISAAC
Short Description: Perl interface to the ISAAC PRNG algorithm
Owners: eseyman
Branches: f14 f15
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-02-25 14:33:43 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-02-27 13:13:59 UTC
Package perl-Math-Random-ISAAC-1.004-2.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Math-Random-ISAAC-1.004-2.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/perl-Math-Random-ISAAC-1.004-2.fc15
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2011-03-01 06:47:34 UTC
perl-Math-Random-ISAAC-1.004-2.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Math-Random-ISAAC'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Math-Random-ISAAC-1.004-2.fc15

Comment 6 Fedora Update System 2011-03-05 02:38:31 UTC
perl-Math-Random-ISAAC-1.004-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Emmanuel Seyman 2011-03-10 22:24:59 UTC
Package Change Request
======================
Package Name: perl-Math-Random-ISAAC
New Branches: f14
Owners: eseyman
InitialCC: perl-sig

Comment 8 Jason Tibbitts 2011-03-10 22:30:04 UTC
This package already has an f14 branch.

Comment 9 Emmanuel Seyman 2014-08-04 09:32:29 UTC
Requesting an EPEL-7 branch

Package Change Request
======================
Package Name: perl-Math-Random-ISAAC
New Branches: epel7
Owners: eseyman
InitialCC:

Comment 10 Gwyn Ciesla 2014-08-04 12:03:52 UTC
Git done (by process-git-requests).

Comment 11 David Dick 2015-03-29 10:24:31 UTC
Hi Emmanuel,

Can you build this for EL6?  If you don't want to, i'm happy to build it myself.

Sample build supplied at http://koji.fedoraproject.org/koji/taskinfo?taskID=9359071

Comment 12 Emmanuel Seyman 2015-03-31 07:33:15 UTC
Go for it, David. I'm not really interested in EPEL-6, these days.

Comment 13 David Dick 2015-03-31 10:41:48 UTC
Thanks Emmanuel.

Package Change Request
======================
Package Name: perl-Math-Random-ISAAC
New Branches: el6
Owners: ddick
InitialCC: perl-sig

Comment 14 Gwyn Ciesla 2015-03-31 13:36:19 UTC
Git done (by process-git-requests).

Comment 15 Fedora Update System 2015-04-01 10:39:44 UTC
perl-Math-Random-ISAAC-1.004-13.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Math-Random-ISAAC-1.004-13.el6

Comment 16 Fedora Update System 2015-04-17 18:15:03 UTC
perl-Math-Random-ISAAC-1.004-13.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.