Bug 682377

Summary: makes assumptions about network device names
Product: [Fedora] Fedora Reporter: Bill Nottingham <notting>
Component: powertopAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 15CC: jskarvad, metherid, rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 682378 (view as bug list) Environment:
Last Closed: 2011-03-11 22:11:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 682334    

Description Bill Nottingham 2011-03-05 01:46:13 UTC 
Description of problem:

Network devices can have arbitrary names, and due to
http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have
different names in Fedora 15.

powertop-1.13/ethernet.c:

The wake-on-lan tests and the wake-on-lan disable both hardcode 'eth0'.

powertop-1.13/powertop.c:static void do_proc_irq(void)
...
                /* deal with multi-queue NICs */
                if (strncmp(name, "eth",3) == 0 && strchr(name,' ') == NULL) {
                        c = strchr(name, '-');
                        if (c)
                                *c = 0;
                }
...

This implies this will mishandle any devices *not* named ethX, if they have multiple queues.

Version-Release number of selected component (if applicable):

powertop-1.13

How reproducible:

By visual inspection.
Comment 1 Jaroslav Škarvada 2011-03-11 22:11:44 UTC 
It doesn't seem to affect the powertop-2.x (1.97+).