Bug 682377 - makes assumptions about network device names
Summary: makes assumptions about network device names
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: powertop
Version: 15
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jaroslav Škarvada
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 682334
TreeView+ depends on / blocked
 
Reported: 2011-03-05 01:46 UTC by Bill Nottingham
Modified: 2014-03-17 03:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
: 682378 (view as bug list)
Environment:
Last Closed: 2011-03-11 22:11:44 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Bill Nottingham 2011-03-05 01:46:13 UTC
Description of problem:

Network devices can have arbitrary names, and due to
http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have
different names in Fedora 15.

powertop-1.13/ethernet.c:

The wake-on-lan tests and the wake-on-lan disable both hardcode 'eth0'.

powertop-1.13/powertop.c:static void do_proc_irq(void)
...
                /* deal with multi-queue NICs */
                if (strncmp(name, "eth",3) == 0 && strchr(name,' ') == NULL) {
                        c = strchr(name, '-');
                        if (c)
                                *c = 0;
                }
...

This implies this will mishandle any devices *not* named ethX, if they have multiple queues.

Version-Release number of selected component (if applicable):

powertop-1.13

How reproducible:

By visual inspection.

Comment 1 Jaroslav Škarvada 2011-03-11 22:11:44 UTC
It doesn't seem to affect the powertop-2.x (1.97+).


Note You need to log in before you can comment on or make changes to this bug.