Bug 714491
| Summary: | Review Request: xmodconfig - A graphical front end for xmodmap | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanchuan Nian <ycnian> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, notting, veeti.paananen, volker27 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-12 16:35:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Yanchuan Nian
2011-06-19 16:08:39 UTC
Here are two packages I have reviewed. https://bugzilla.redhat.com/show_bug.cgi?id=708664 https://bugzilla.redhat.com/show_bug.cgi?id=708664 Thanks. Sorry for the wrong links. https://bugzilla.redhat.com/show_bug.cgi?id=711764 https://bugzilla.redhat.com/show_bug.cgi?id=708664 I will continue to make comments on other tictets. Just commenting: you might want to change the SourceForge URL to follow this format: http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net Hi Veeti, Thanks for your comment.New updated srpm and spec: http://k002.kiwi6.com/hotlink/ay64znuzpv/xmodconfig.spec http://k002.kiwi6.com/hotlink/br3f6seag8/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm Informal review comment, The description is not completely clear, ...keyboard-mapping `as you can use only one application to do anything needed to use xmodmap`, including... I am not sure what you mean between the `` do you mean; there is only one application to achieve the functionality, or; you can only use one application to achieve this functionality? (rpmlint was clean for the spec file and rpmlint SRPMS/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm gave three spelling warnings) Damian Brasher Don't install README. It only contains information on installing.
There should only be a space between BuildRequires -- no comma. It's even nicer to put each on a separate line.
I agree with Damian on the comment. Try to rephrase that and maybe split the sentence in two.
If you don't want to maintain this package in EPEL5 or older, you can drop the clean section, omit the rm buildroot and remove the BuildRoot definition.
You can leave out defattr in general.
Maybe make a comment on why you rm -rf %{buildroot}%{_docdir}.
Besides these things, that are mostly not blockers, I think the file is fine.
Sorry I'm busy these days. I will update the package as soon as possible, maybe this evening or tomorrow.Thanks. Thanks for all the help.New specfile and package http://k002.kiwi6.com/hotlink/3hul1mci0d/xmodconfig.spec http://k002.kiwi6.com/hotlink/92z1m4l2ne/xmodconfig-0.2.0-0.3.beta.fc15.src.rpm Did you try to find a sponsor yet? http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Any news here? |