Bug 714491 - Review Request: xmodconfig - A graphical front end for xmodmap
Review Request: xmodconfig - A graphical front end for xmodmap
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2011-06-19 12:08 EDT by Yanchuan Nian
Modified: 2013-10-19 10:42 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-02-12 11:35:30 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Yanchuan Nian 2011-06-19 12:08:39 EDT
Spec URL: http://k002.kiwi6.com/hotlink/0l5iz7lr5d/xmodconfig.spec
SRPM URL: http://k002.kiwi6.com/hotlink/c8d1760j9t/xmodconfig-0.2.0-0.1.beta.fc15.src.rpm

Description: xmodconfig is a graphical front end for xmodmap. It enables you to configure xmodmap files without using a texteditor or any additional application such as xev, so you can configure your key mapping without any knowledge of the syntax of xmodmap.

Here is the result of rpmlint:
rpmlint xmodconfig-0.2.0-0.1.beta.fc15.i686.rpm xmodconfig-0.2.0-0.1.beta.fc15.src.rpm /home/nian/rpmbuild/SPECS/xmodconfig.spec 
xmodconfig.i686: W: spelling-error Summary(en_US) xmodmap -> woodman
xmodconfig.i686: W: spelling-error %description -l en_US xmodmap -> woodman
xmodconfig.i686: W: spelling-error %description -l en_US keycodes -> key codes, key-codes, encodes
xmodconfig.src: W: spelling-error Summary(en_US) xmodmap -> woodman
xmodconfig.src: W: spelling-error %description -l en_US xmodmap -> woodman
xmodconfig.src: W: spelling-error %description -l en_US keycodes -> key codes, key-codes, encodes
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

This is my first package and I need a sponsor.Thanks.
Comment 1 Yanchuan Nian 2011-06-19 12:20:21 EDT
Here are two packages I have reviewed.
https://bugzilla.redhat.com/show_bug.cgi?id=708664
https://bugzilla.redhat.com/show_bug.cgi?id=708664
Thanks.
Comment 2 Yanchuan Nian 2011-06-19 12:39:08 EDT
Sorry for the wrong links.
https://bugzilla.redhat.com/show_bug.cgi?id=711764
https://bugzilla.redhat.com/show_bug.cgi?id=708664
I will continue to make comments on other tictets.
Comment 3 Veeti Paananen 2011-06-20 17:58:43 EDT
Just commenting: you might want to change the SourceForge URL to follow this format:

http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
Comment 4 Yanchuan Nian 2011-06-21 08:53:28 EDT
Hi Veeti,
Thanks for your comment.New updated srpm and spec:
http://k002.kiwi6.com/hotlink/ay64znuzpv/xmodconfig.spec
http://k002.kiwi6.com/hotlink/br3f6seag8/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm
Comment 5 Damian L Brasher 2011-06-26 09:13:55 EDT
Informal review comment,

The description is not completely clear, 

...keyboard-mapping `as you can use only one application to do anything needed to use xmodmap`, including...

I am not sure what you mean between the `` do you mean; there is only one application to achieve the functionality, or; you can only use one application to achieve this functionality?

(rpmlint was clean for the spec file and rpmlint SRPMS/xmodconfig-0.2.0-0.2.beta.fc15.src.rpm gave three spelling warnings)

Damian Brasher
Comment 6 Volker Fröhlich 2011-06-27 17:02:58 EDT
Don't install README. It only contains information on installing.

There should only be a space between BuildRequires -- no comma. It's even nicer to put each on a separate line.

I agree with Damian on the comment. Try to rephrase that and maybe split the sentence in two.

If you don't want to maintain this package in EPEL5 or older, you can drop the clean section, omit the rm buildroot and remove the BuildRoot definition.

You can leave out defattr in general.

Maybe make a comment on why you rm -rf %{buildroot}%{_docdir}.

Besides these things, that are mostly not blockers, I think the file is fine.
Comment 7 Yanchuan Nian 2011-06-27 21:03:30 EDT
Sorry I'm busy these days. I will update the package as soon as possible, maybe this evening or tomorrow.Thanks.
Comment 9 Volker Fröhlich 2011-09-16 17:04:27 EDT
Did you try to find a sponsor yet?

http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Comment 10 Volker Fröhlich 2011-12-13 14:34:27 EST
Any news here?

Note You need to log in before you can comment on or make changes to this bug.