Bug 719328 (gwenview)
Summary: | Review Request: gwenview - An image viewer | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
Component: | Package Review | Assignee: | nucleo <alekcejk> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | alekcejk, notting, package-review, pahan |
Target Milestone: | --- | Flags: | alekcejk:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-07-18 20:34:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 719323 | ||
Bug Blocks: | 712882 |
Description
Rex Dieter
2011-07-06 14:00:30 UTC
It is already in kdegraphics: $ rpm -qf `which gwenview` kdegraphics-4.6.3-1.fc15.i686 Do you plan separate it? Yes, F16 KDE47 feature includes (some) separated/split packaging, including all kdegraphics components. Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/gwenview.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/gwenview-4.6.95-1.fc15.src.rpm %changelog * Mon Jul 11 2011 Rex Dieter <rdieter> 4.6.95-1 - 4.6.95 - update URL * Wed Jul 06 2011 Rex Dieter <rdieter> 4.6.90-2 - fix Source0 URL - Conflicts: kdegraphics < 7:4.6.90-10 Ugh. :) Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/gwenview.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/gwenview-4.6.95-2.fc15.src.rpm %changelog * Mon Jul 18 2011 Rex Dieter <rdieter> 4.6.95-2 - License: GPLv2+ - -libs: License: IJG and LGPLv2+ and GPLv2+ and LGPLv2 or LGPLv3 or LGPLv3+ (KDE e.V.) /usr/bin/update-desktop-database &> /dev/null || : should be in %post and %postun also needed Requires(post): desktop-file-utils Requires(postun): desktop-file-utils sorry, this requires only for older releases Package and spec names are fine, licenses fine (GPLv2+ for main package, for -libs IJG and LGPLv2+ and GPLv2+ and LGPLv2 or LGPLv3) scriptlets are fine (/sbin/ldconfig in -libs and desktop-database and mimeinfo in main package) Package builds in mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=3207961 gwenview.i686: E: script-without-shebang /usr/share/applications/kde4/gwenview.desktop gwenview.i686: W: no-manual-page-for-binary gwenview gwenview.i686: W: no-manual-page-for-binary gwenview_importer gwenview.x86_64: E: script-without-shebang /usr/share/applications/kde4/gwenview.desktop gwenview.x86_64: W: no-manual-page-for-binary gwenview gwenview.x86_64: W: no-manual-page-for-binary gwenview_importer gwenview-libs.i686: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment gwenview-libs.i686: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment gwenview-libs.i686: W: invalid-license KDE e.V. gwenview-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment gwenview-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment gwenview-libs.x86_64: W: invalid-license KDE e.V. 7 packages and 0 specfiles checked; 2 errors, 10 warnings. invalid-license fixed in updated gwenview.spec Since update-desktop-database also fixed package APPROVED imported. f15 branch also needed? yeah, probably should just in case, Package Change Request ====================== Package Name: gwenview Branches: f15 Should this not be a New Package Request? gwenview module already exists, so, no? Yes, but this request is misformatted. https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages sorry, copy and paste fail it seems. let's try one more time. Package Change Request ====================== Package Name: gwenview New Branches: f15 You also need to fill in owner. ok, it's just that last time I tried to update owners via a package change request, I was told that didn't work, https://bugzilla.redhat.com/show_bug.cgi?id=719323#c15 whatever... Package Change Request ====================== Package Name: gwenview New Branches: f15 Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Git done (by process-git-requests). That's correct. This is a new branch, so you set the owners in the SCM request. If the branch exists, the prospective owners need to request access in pkgdb and then the primary owner can approve. |