| Summary: | Review Request: okular - A document viewer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | alekcejk, jreznik, notting, package-review |
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-07-15 14:35:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 719323 | ||
| Bug Blocks: | 712882 | ||
|
Description
Rex Dieter
2011-07-06 14:12:04 UTC
URL can be http://okular.kde.org/ or http://www.kde.org/applications/graphics/okular/. Maybe first is preferred. Name: ok
Summary:
License: ok
URL: I think anyone from this three is ok, still better than just kde.org
Sources: ok (md5sum 021e4ad479bb88937084d4510d1e1218)
BRs: ok
Conflicts: ok
Desktop file validation: ok
Updated icon cache: ok
Macros used consistently: ok
Docs: ok
Ldconfig: ok
Devel contains .so: ok, library itself in -lib subpackage
rpmlint okular.spec
okular.spec:84: W: macro-in-comment %{buildroot}
okular.spec:84: W: macro-in-comment %{_kde4_libdir}
#unpackaged files - commented out but contains libgwenview, is it intended? otherwise please remove this line
okular.spec: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/okular-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.>
0 packages and 1 specfiles checked; 0 errors, 3 warnings.
APPROVED, just fix the rpmlint issue
New Package SCM Request ======================= Package Name: okular Short Description: A document viewer Owners: than rdieter jreznik ltinkl rnovacek kkofler Branches: f15 Git done (by process-git-requests). imported. BR: qca2-devel should be added? It is missing in build log http://kojipkgs.fedoraproject.org/packages/okular/4.6.95/2.fc16/data/logs/i686/build.log ----------------------------------------------------------------------------- -- The following OPTIONAL packages could NOT be located on your system. -- Consider installing them to enable more features from this software. ----------------------------------------------------------------------------- * QCA (2.0.0 or higher) <http://delta.affinix.com/qca/> Qt Cryptographic Architecture (QCA) Support for encrypted OpenDocument Text documents in Okular. yep, thanks. |