Bug 732846
| Summary: | Syntax errors in JavaScript cause jammit to fail silently and RPMs get 0 byte files | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Mike McCune <mmccune> |
| Component: | WebUI | Assignee: | Mike McCune <mmccune> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Katello QA List <katello-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.0 | CC: | bkearney |
| Target Milestone: | Unspecified | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-22 17:53:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 747354 | ||
*** Bug 732454 has been marked as a duplicate of this bug. *** I have seen this work. |
If there are syntax errors in any of our JavaScript files the jammit run during the RPM build will output 0 byte javascript files for the ones containing errors. We discovered that we were using the reserved word: "package" for a variable in promotions.js: promotion.js /home/mmccune/devel/katello/src/public/javascripts/promotion.js(245): SyntaxError: missing name after . operator if( !product.errata.length && !product.package.length && !product.repo.length ){ ...........................................................^ You can see that .package is a reserved word: https://developer.mozilla.org/en/JavaScript/Reference/reserved_words Going to add a jslint run to our unit tests to catch these.