Bug 738742
| Summary: | Review Request: rubygem-coffee-script - Ruby CoffeeScript Compiler | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fotios Lindiakos <fotios> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bkabrda, jkeck, notting, package-review, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AwaitingSubmitter | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-18 05:44:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 738744, 738746 | ||
| Bug Blocks: | 738465 | ||
|
Description
Fotios Lindiakos
2011-09-15 17:27:42 UTC
I don't know very much about ruby, but this package doesn't appear to follow the current guidelines very closely at all. https://fedoraproject.org/wiki/Packaging:Ruby Not knowing ruby I can't comment on how important those differences actually are. Perhaps you could comment on those differences. Since Fotios has been inactive for quite some time, I'll take this review over. So here are the updated spec and srpm, I created them completely from scratch: SPEC: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script.spec SRPM: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script-2.2.0-1.fc17.src.rpm Description: Ruby CoffeeScript is a bridge to the JS CoffeeScript compiler. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4246436 * The test should be expanded in %check section
- I would prefer if the test suite is expanded in the %check section, since
in that case, you will avoid the RPM polution. Although admittedly, the
%patch macro does not work there, but you can use something like:
cat %{PATCH0} | patch -p1
Since this is just minor nit and the package looks reasonable otherwise, I APPROVE the package.
Thanks, I will fix this before importing. New Package SCM Request ======================= Package Name: rubygem-coffee-script Short Description: Ruby CoffeeScript Compiler Owners: bkabrda Branches: InitialCC: Git done (by process-git-requests). |