Bug 738742 - Review Request: rubygem-coffee-script - Ruby CoffeeScript Compiler
Summary: Review Request: rubygem-coffee-script - Ruby CoffeeScript Compiler
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AwaitingSubmitter
Depends On: 738744 738746
Blocks: 738465
TreeView+ depends on / blocked
 
Reported: 2011-09-15 17:27 UTC by Fotios Lindiakos
Modified: 2014-01-13 01:42 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-18 05:44:01 UTC
vondruch: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Fotios Lindiakos 2011-09-15 17:27:42 UTC
Spec URL: https://raw.github.com/fotioslindiakos/rubygem-all/master/SPECS/rubygem-coffee-script.spec

SRPM URL: https://github.com/fotioslindiakos/rubygem-all/raw/master/SRPMS/rubygem-coffee-script-2.2.0-1.fc15.src.rpm

Description: Ruby CoffeeScript is a bridge to the JS CoffeeScript compiler.

Comment 1 Jason Tibbitts 2012-06-30 00:37:18 UTC
I don't know very much about ruby, but this package doesn't appear to follow the current guidelines very closely at all.  https://fedoraproject.org/wiki/Packaging:Ruby

Not knowing ruby I can't comment on how important those differences actually are.  Perhaps you could comment on those differences.

Comment 2 Bohuslav "Slavek" Kabrda 2012-07-17 13:33:12 UTC
Since Fotios has been inactive for quite some time, I'll take this review over.

Comment 3 Bohuslav "Slavek" Kabrda 2012-07-17 13:45:44 UTC
So here are the updated spec and srpm, I created them completely from scratch:

SPEC: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script.spec
SRPM: http://bkabrda.fedorapeople.org/pkgs/coffee-script/rubygem-coffee-script-2.2.0-1.fc17.src.rpm
Description: Ruby CoffeeScript is a bridge to the JS CoffeeScript compiler.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4246436

Comment 4 Vít Ondruch 2012-07-17 14:39:54 UTC
* The test should be expanded in %check section
  - I would prefer if the test suite is expanded in the %check section, since
    in that case, you will avoid the RPM polution. Although admittedly, the
    %patch macro does not work there, but you can use something like:

    cat %{PATCH0} | patch -p1

Since this is just minor nit and the package looks reasonable otherwise, I APPROVE the package.

Comment 5 Bohuslav "Slavek" Kabrda 2012-07-17 14:41:54 UTC
Thanks, I will fix this before importing.

New Package SCM Request
=======================
Package Name: rubygem-coffee-script
Short Description: Ruby CoffeeScript Compiler
Owners: bkabrda
Branches: 
InitialCC:

Comment 6 Gwyn Ciesla 2012-07-18 03:13:25 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.