Red Hat Bugzilla – Bug 738746
Review Request: rubygem-coffee-script-source - The CoffeeScript Compiler
Last modified: 2014-01-12 20:42:31 EST
Spec URL: https://raw.github.com/fotioslindiakos/rubygem-all/master/SPECS/rubygem-coffee-script-source.spec
SRPM URL: https://github.com/fotioslindiakos/rubygem-all/raw/master/SRPMS/rubygem-coffee-script-source-1.1.2-1.fc15.src.rpm
in a simple way.
I'll take this one.
- Please update to the latest upstream version (currently 1.2.0).
- Consider excluding cached gem. This is only used with "gem pristine" command, which is irrelevant for RPM gems, as they should be restored by "yum reinstall".
* You probably haven't noticed, but we are moving to Ruby 1.9.3 in rawhide, which involves some changes to the gem packaging - see  for new guidelines draft. Some information can be found on Ruby-sig fedora mailing list  (you should subscribe to that one, if you haven't already).
* Currently, we only build new packages for Ruby 1.9.3 in its special target f17-ruby (again, all the info is is ).
* I suggest you update to the latest version, then we can sort out any leftovers and I can also help you with the new-style packaging. The package looks good, so I think it shouldn't be a problem.
Thanks for picking this up! I'll look over those suggestions and update the package to the newest version.
Hi Fotios, any progress on this one? It is a requirement for Rails 3.2 stack, which we would like to get to Rawhide ASAP, so we can have enough time to fix all the things it will break.
Sorry, fell onto the back burner. I'm doing it right now, I'll update when I have a new package for the latest version built against the new guidelines
Updated the package to build against rawhide and Ruby 1.9.1. Links to updated files are included. I also successfully build the package in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3827994
- Please bump the release when doing changes (you can use rpmdev-bumpspec) - or if you are updating to newer version, you still need to add a changelog entry, that notes it.
- According to , you can use the new macros for gem files and directories. The only thing you need to do is define %gem_name, then you will have %gem_instdir, %gem_cache, etc... Also, you should now have BR: rubygems-devel instead of BR: ruby(rubygems) (the runtime dependency however stays on ruby(rubygems) ).
- If there are tests available in the upstream, that are not present in the gem itself, it a good custom to run them. You can see rubygem-delorean as an example how to do that (you have to check them out from git separately in the correct version and add them as another source).
Ok, followed your suggestions and here is a new package (note: SPEC is the same location because it's controlled via git)
(In reply to comment #8)
> Ok, followed your suggestions and here is a new package (note: SPEC is the same
> location because it's controlled via git)
> KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=3840346
> As for tests, there are tests upstream under the coffee-script package (which
> includes this source package and a js runtime), but they can't be run without
> additional dependencies. IMHO, since this source package, installing a
> having a package with no deps. But this is my first package, so if that is a
> common thing to do, let me know, I'd be happy to take care of it.
Well, my idea is, that you only run tests in Build time, not runtime. That way, you may have many BR:, but runtime requires will stay the same.
Hi Fotios, any progress on this? We will need this for new rails in F18, so it would be great to have it ASAP.
Since Fotios seems to be busy, I updated his package to the latest coffee-script-source version to keep going forward:
Please note that the test suite is not possible to Run. The rubygem-coffee-script is testing this package.
> In ideal world, this package should not be needed, since we would have
> independent coffee-script package, build from source. But that would be
> not dive into this "mess".
Not much to review here :) The only thing that comes to my mind is that it might be nice to ask upstream to include a license file in the package, but this is not a blocker. This package is APPROVED.
@Slavek: Thank you for the review. I'll consider it :)
@Fotios: I am going to request the git repository. Please ask for co-maintaining or I am completely fine to hand the package over to you if you like. Just let me know.
New Package SCM Request
Package Name: rubygem-coffee-script-source
Short Description: The CoffeeScript Compiler
Git done (by process-git-requests).