Bug 757239 (kactivities)
| Summary: | Review Request: kactivities - API for using and interacting with Activities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Kevin Kofler <kevin> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-29 14:47:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Rex Dieter
2011-11-25 23:19:30 UTC
I'm taking this review. This has been reviewed and approved very recently in bug #749055, the only thing which has changed is the name (due to upstream). The Obsoletes look correct, but shouldn't we add matching Provides? (rpmlint will complain otherwise, and I think it can't hurt.) Obsoletes: libkactivities < 6.1-100
Provides: libkactivities = 6.1-100
[snip]
%package devel
Summary: Developer files for %{name}
Obsoletes: libkactivities-devel < 6.1-100
Provides: libkactivities-devel = 6.1-100
This is correct, the last libkactivities package was 6.1-2%{?dist} and had no Epoch, going to 100 allows for bugfix builds if needed.
Otherwise, the package hasn't changed since it got approved and I can't see anything wrong with it.
APPROVED
New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkolfer ltinkl rdieter rnovacek Branches: f16 InitialCC: New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkofler ltinkl rdieter rnovacek Branches: f16 InitialCC: It helps if my name is spelled correctly. ;-) Git done (by process-git-requests). imported, built. thanks! |