Spec URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kactivities/kactivities-4.7.80-1.fc16.src.rpm Description: API for using and interacting with Activities Package rename libkactivities -> kactivities mostly.
I'm taking this review. This has been reviewed and approved very recently in bug #749055, the only thing which has changed is the name (due to upstream). The Obsoletes look correct, but shouldn't we add matching Provides? (rpmlint will complain otherwise, and I think it can't hurt.)
Obsoletes: libkactivities < 6.1-100 Provides: libkactivities = 6.1-100 [snip] %package devel Summary: Developer files for %{name} Obsoletes: libkactivities-devel < 6.1-100 Provides: libkactivities-devel = 6.1-100 This is correct, the last libkactivities package was 6.1-2%{?dist} and had no Epoch, going to 100 allows for bugfix builds if needed. Otherwise, the package hasn't changed since it got approved and I can't see anything wrong with it. APPROVED
New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkolfer ltinkl rdieter rnovacek Branches: f16 InitialCC:
New Package SCM Request ======================= Package Name: kactivities Short Description: API for using and interacting with Activities Owners: than jreznik kkofler ltinkl rdieter rnovacek Branches: f16 InitialCC: It helps if my name is spelled correctly. ;-)
Git done (by process-git-requests).
imported, built. thanks!