| Summary: | Review Request: oxygen-gtk3 - Oxygen GTK+3 theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | nucleo <alekcejk> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | baifcc, kevin, notting, package-review, rdieter, tchollingsworth |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | oxygen-gtk3-1.0.0-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-08 22:34:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
nucleo
2011-12-19 17:24:26 UTC
*** Bug 753535 has been marked as a duplicate of this bug. *** Just an informal review... (In reply to comment #0) > rpmlint output: > rpmlint oxygen-gtk3.spec oxygen-gtk3-1.2.0-0.1.20111219.fc16.src.rpm > oxygen-gtk3.spec:13: W: macro-in-comment %{version} > oxygen-gtk3.spec:13: W: macro-in-comment %{version} > oxygen-gtk3.spec:13: W: macro-in-comment %{snap} > oxygen-gtk3.src:13: W: macro-in-comment %{version} > oxygen-gtk3.src:13: W: macro-in-comment %{version} > oxygen-gtk3.src:13: W: macro-in-comment %{snap} Please escape RPM macros in comments like "%%{version}". Other than that, the packaging looks good, it builds fine, and works great! Thanks a lot; I've been hoping to see this for awhile. Thanks. I will fix comments with next snapshot or remove them if package will be reviewed when oxygen-gtk3-1.2.0 released (then snapshot comments will be not needed). excellent, thanks to all of you. Ping? Any news? I guess I can formally review this. naming: ok license: ok sources: ok (snapshot for now) macros: ok scriptlets: n/a otherwise, fairly simple and close to existing oxygen-gtk2 packaging. Looks good. APPROVED. Thanks. There was no any commits to gtk3 branch, so no need to do new snapshot. I will fix macro-in-comment when importing this package in git. New Package SCM Request ======================= Package Name: oxygen-gtk3 Short Description: Oxygen GTK+3 theme Owners: rdieter nucleo Branches: f15 f16 Git done (by process-git-requests). Built for Rawhide. oxygen-gtk3-1.2.0-0.1.20111219.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/oxygen-gtk3-1.2.0-0.1.20111219.fc15 oxygen-gtk3-1.2.0-0.1.20111219.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/oxygen-gtk3-1.2.0-0.1.20111219.fc16 oxygen-gtk3-1.0.0-1.fc16 has been pushed to the Fedora 16 stable repository. oxygen-gtk3-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository. |