Bug 785466 (horde-http)

Updated

Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Http.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Http-1.1.1-1.fc16.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4255225

Licensing looks good. Koji scratch builds OK, naming looks good.

rpmlint:
[dan@f172 SPECS]$ rpmlint php-horde-Horde-Http.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[dan@f172 SPECS]$ rpmlint php-horde-Horde-Http-1.1.0-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


4255168 build (f17, php-horde-Horde-Http-1.1.0-1.fc16.src.rpm) completed successfully
4255225 build (f18, php-horde-Horde-Http-1.1.0-1.fc16.src.rpm) completed successfully
4255275 build (f16, php-horde-Horde-Http-1.1.0-1.fc16.src.rpm) completed successfully


You may want to look into these warnings (not sure if they matter):

+ /usr/bin/pear install --nodeps --packagingroot /builddir/build/BUILDROOT/php-horde-Horde-Http-1.1.0-1.fc16.noarch php-horde-Horde-Http.xml
warning: channel://pear.horde.org/Horde_Http-1.1.0 requires package "channel://pear.horde.org/Horde_Exception" (version >= 1.0.0, version <= 2.0.0, excluded versions: 2.0.0)
warning: channel://pear.horde.org/Horde_Http-1.1.0 requires package "channel://pear.horde.org/Horde_Support" (version >= 1.0.0, version <= 2.0.0, excluded versions: 2.0.0)
channel://pear.horde.org/Horde_Http-1.1.0 can optionally use package "channel://pear.horde.org/Horde_Test" (version >= 1.0.0, version <= 2.0.0, excluded versions: 2.0.0)
channel://pear.horde.org/Horde_Http-1.1.0 can optionally use PHP extension "http"
install ok: channel://pear.horde.org/Horde_Http-1.1.0

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    BSD
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum Horde_Http-1.1.1.tgz
2e34f5965cc426571534684e4cbac576  Horde_Http-1.1.1.tgz


[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
- See Koji build above.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[.] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...

[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[.] SHOULD: The reviewer should test that the package functions as described.
    Works fine on my system (metacity part not tested)
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.

----------------

PACKAGE APPROVED

----------------

New Package SCM Request
=======================
Package Name: php-horde-Horde-Http
Short Description: This package provides a set of classes for making HTTP requests.
Owners: nb vicodan
Branches: f16 f17

Git done (by process-git-requests).

Package Change Request
======================
Package Name: php-horde-Horde-Http
New Branches: el6
Owners: nb
InitialCC:

Git done (by process-git-requests).

(In reply to comment #2)

I just wanted to quickly comment on:
> You may want to look into these warnings (not sure if they matter):

> warning: channel://pear.horde.org/Horde_Http-1.1.0 requires package
> "channel://pear.horde.org/Horde_Exception" (version >= 1.0.0, version <=
> 2.0.0, excluded versions: 2.0.0)
> warning: channel://pear.horde.org/Horde_Http-1.1.0 requires package
> "channel://pear.horde.org/Horde_Support" (version >= 1.0.0, version <=
> 2.0.0, excluded versions: 2.0.0)

These requires matter because they are must have dependencies for this package.  The spec satisfies these requirements with:
Requires:       php-pear(pear.horde.org/Horde_Exception) < 2.0.0
Requires:       php-pear(pear.horde.org/Horde_Support) < 2.0.0 

> channel://pear.horde.org/Horde_Http-1.1.0 can optionally use package
> "channel://pear.horde.org/Horde_Test" (version >= 1.0.0, version <= 2.0.0,
> excluded versions: 2.0.0)
> channel://pear.horde.org/Horde_Http-1.1.0 can optionally use PHP extension
> "http"
> install ok: channel://pear.horde.org/Horde_Http-1.1.0

The are optional dependencies and it is up to the packager to decide to require them or not.

Nick,

Please push this through bodhi and add the bug number so this bug can be automatically closed by bodhi.

Thanks,
Dan