Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Exception.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Exception-1.0.8-1.fc16.src.rpm Description: This class provides the default exception handlers for the Horde Application Framework.
According to upstream (package.xml), this requires: BuildRequires: php-pear(PEAR) >= 1.7.0 Requires: php-common >= 5.2.0 Avoir conflicts pear-pear(pear.horde.org/Horde_Translation) >= 1.0.0 pear-pear(pear.horde.org/Horde_Translation) < 2.0.0 %file %{pear_xmldir}/%{name}.xml %{pear_phpdir}/Horde/Exception %{pear_phpdir}/Horde/Exception.php %{pear_datadir}/Horde_Exception %{pear_testdir}/Horde_Exception
Updated.
License is LGPLv2+ This package must handle locales properly, http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
Updated
We need to discuss about locales in this package (and probably the other php-horde-*) With current spec warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ar/LC_MESSAGES/Horde_Exception.mo warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bg/LC_MESSAGES/Horde_Exception.mo warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/bs/LC_MESSAGES/Horde_Exception.mo warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/ca/LC_MESSAGES/Horde_Exception.mo warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/cs/LC_MESSAGES/Horde_Exception.mo warning: File listed twice: /usr/share/pear/data/Horde_Exception/locale/da/LC_MESSAGES/Horde_Exception.mo ... %dir %{pear_datadir}/Horde_Exception should be enough, but it also contains .pot and .po files. I really don't think this are needed, as Horde_Translation use "gettext" by default (but I don't know if others backend are available in Horde stack, which requires .po) Could you please ask upstream about this ? (better solution to exclude files, is to delete lines in the package.xml, to keep "pear list-files" report consistent)
I think this one is ready to review.
I made the changes you suggested via email.
it seems you have forgotten to update/upload the new spec/srpm (last is January 30)
I've uploaded it now.
This one is ok (Package must own all directories that it creates.) You could removed Requires: php-channel(pear.horde.org) As this package is already required by php-pear(pear.horde.org/Horde_Translation) This package is APPROVED (must wait for Horde_Translation before importing to repo)
New Package SCM Request ======================= Package Name: php-horde-Horde-Exception Short Description: Provides the default exception handlers for the Horde Application Framework Owners: nb Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests).