Bug 788500

Summary: redis bundles jemalloc and hiredis and lua
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: redisAssignee: Nathan Scott <nathans>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: carl, fedora, i, misc, nathans, silas
Target Milestone: ---Keywords: Tracking
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 788517    
Bug Blocks: 504493    
Attachments:
Description Flags
proposed fix none

Description Dan Horák 2012-02-08 05:30:34 EST
redis builds against bundled jemalloc and hiredis libraries when system copies should be used. See http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries for more information.
Comment 1 Dan Horák 2012-02-08 06:11:05 EST
Created attachment 560227 [details]
proposed fix
Comment 2 Dan Horák 2013-01-02 16:22:09 EST
and also lua is bundled
Comment 3 Michael Scherer 2013-01-12 17:58:58 EST
*** Bug 894657 has been marked as a duplicate of this bug. ***
Comment 4 Fedora End Of Life 2013-04-03 13:34:06 EDT
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19
Comment 5 Michael Scherer 2013-07-02 11:43:33 EDT
It also bundle linenoise, which is packaged.
Comment 6 Michael Scherer 2013-07-02 12:27:36 EDT
It seems that linenoise cannot be unbundled, because it use a different version from the one in Fedora, and porting redis to the fedora version imply to either export internal function, or to drop "clear" command from redis-cli.
Comment 7 Christopher Meng 2014-06-18 22:41:31 EDT
Status update: jemalloc is unbundled now.

linenoise can't be unbundled, it's a copylib IMO and being used by android also.

hiredis is another upstream project(C client), I don't understand why they make it static in the project, investigation needed.
Comment 8 Christopher Meng 2014-06-19 06:51:34 EDT
Lua could be granted an exception maybe, as the lua bundled in redis bundles following 3rd party lua modules:

    luaLoadLib(lua, "cjson", luaopen_cjson);
    luaLoadLib(lua, "struct", luaopen_struct);
    luaLoadLib(lua, "cmsgpack", luaopen_cmsgpack);
Comment 9 Remi Collet 2014-07-27 07:30:29 EDT
Please open FPC request for bundling exception.
Comment 10 Christopher Meng 2014-07-27 08:38:36 EDT
*** Bug 1123631 has been marked as a duplicate of this bug. ***
Comment 11 Christopher Meng 2014-07-27 08:39:29 EDT
*** Bug 1123632 has been marked as a duplicate of this bug. ***
Comment 12 Nathan Scott 2017-09-06 03:22:08 EDT
> hiredis is another upstream project(C client), I don't understand why they make > it static in the project, investigation needed.

FWIW, Remi offered this explanation to this when I recently asked ...

        hiredis 0.13 is very old, but is also the official "stable" release of
        the client library.

        Redis use a more recent version, but not yet released.

        As Redis is also upstream is for hiredis, I think this is totally fine
        to use the bundled version.

Looking at hiredis upstream github, it's been ~2 years since last release so I tend to agree with this assessment.

As mentioned earlier, the jemalloc bundling has long been removed.

I'll add these lines to the next redis build, as suggested by Remi and Haïkel:
Provides:          bundled(hiredis)
Provides:          bundled(lua-libs)
Provides:          bundled(linenoise)