Bug 798196

Summary:	virt-resize confuses format and output_format variables; using --output-format sets the input format
Product:	[Community] Virtualization Tools	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED UPSTREAM	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	mbooth, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	798197 (view as bug list)		Environment:
Last Closed:	2012-02-28 10:35:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	798197

Description Richard W.M. Jones 2012-02-28 09:51:36 UTC

Description of problem:

virt-resize --output-format raw sets the *input* format to raw.
This is because the code for the --output-format flag is
accidentally setting the format variable (not output_format):

https://github.com/libguestfs/libguestfs/blob/a93d4a9dc1aea6940886c85d4b09f21cbfc80969/resize/resize.ml#L101

(Bug found by Grant Williamson)

Version-Release number of selected component (if applicable):

1.17.8

How reproducible:

100%

Steps to Reproduce:
http://pastebin.com/VpsNjYEa

Comment 1 Richard W.M. Jones 2012-02-28 10:35:53 UTC

Fix pushed upstream here:
https://github.com/libguestfs/libguestfs/commit/88ba4da4d6c07762fc95c96ea67019f0ebf4677c