Bug 798197 - virt-resize confuses format and output_format variables; using --output-format sets the input format
Summary: virt-resize confuses format and output_format variables; using --output-forma...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libguestfs
Version: 6.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 798196
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-02-28 09:52 UTC by Richard W.M. Jones
Modified: 2012-06-20 07:00 UTC (History)
8 users (show)

Fixed In Version: libguestfs-1.16.6-1.el6
Doc Type: Bug Fix
Doc Text:
No Documentation needed
Clone Of: 798196
Environment:
Last Closed: 2012-06-20 07:00:53 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0774 0 normal SHIPPED_LIVE Low: libguestfs security, bug fix, and enhancement update 2012-06-19 19:29:50 UTC

Description Richard W.M. Jones 2012-02-28 09:52:48 UTC 
+++ This bug was initially created as a clone of Bug #798196 +++

Description of problem:

virt-resize --output-format raw sets the *input* format to raw.
This is because the code for the --output-format flag is
accidentally setting the format variable (not output_format):

https://github.com/libguestfs/libguestfs/blob/a93d4a9dc1aea6940886c85d4b09f21cbfc80969/resize/resize.ml#L101

(Bug found by Grant Williamson)

Version-Release number of selected component (if applicable):

1.17.8

How reproducible:

100%

Steps to Reproduce:
http://pastebin.com/VpsNjYEa
Comment 2 Richard W.M. Jones 2012-02-28 10:36:14 UTC 
Upstream fix:
https://github.com/libguestfs/libguestfs/commit/88ba4da4d6c07762fc95c96ea67019f0ebf4677c
Comment 6 Richard W.M. Jones 2012-04-26 12:21:52 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation needed
Comment 8 errata-xmlrpc 2012-06-20 07:00:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0774.html
Note You need to log in before you can comment on or make changes to this bug.