Bug 798197 – virt-resize confuses format and output_format variables; using --output-format sets the input format

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 798197 - virt-resize confuses format and output_format variables; using --output-format sets the input format

Summary:	virt-resize confuses format and output_format variables; using --output-forma...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libguestfs (Show other bugs)
Sub Component:
Version:	6.3
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	rc
Target Release:	---
Assigned To:	Richard W.M. Jones
QA Contact:	Virtualization Bugs
Docs Contact:

URL:
Whiteboard:
Keywords:	Regression

Depends On:	798196
Blocks:
	Show dependency tree / graph

Reported:	2012-02-28 04:52 EST by Richard W.M. Jones
Modified:	2012-06-20 03:00 EDT (History)
CC List:	8 users (show)

See Also:
Fixed In Version:	libguestfs-1.16.6-1.el6
Doc Type:	Bug Fix
Doc Text:	No Documentation needed
Story Points:	---
Clone Of:	798196
Environment:
Last Closed:	2012-06-20 03:00:53 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2012:0774	normal	SHIPPED_LIVE	Low: libguestfs security, bug fix, and enhancement update	2012-06-19 15:29:50 EDT

Groups: None (edit)

Description Richard W.M. Jones 2012-02-28 04:52:48 EST

+++ This bug was initially created as a clone of Bug #798196 +++

Description of problem:

virt-resize --output-format raw sets the *input* format to raw.
This is because the code for the --output-format flag is
accidentally setting the format variable (not output_format):

https://github.com/libguestfs/libguestfs/blob/a93d4a9dc1aea6940886c85d4b09f21cbfc80969/resize/resize.ml#L101

(Bug found by Grant Williamson)

Version-Release number of selected component (if applicable):

1.17.8

How reproducible:

100%

Steps to Reproduce:
http://pastebin.com/VpsNjYEa

Comment 2 Richard W.M. Jones 2012-02-28 05:36:14 EST

Upstream fix:
https://github.com/libguestfs/libguestfs/commit/88ba4da4d6c07762fc95c96ea67019f0ebf4677c

Comment 6 Richard W.M. Jones 2012-04-26 08:21:52 EDT

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation needed

Comment 8 errata-xmlrpc 2012-06-20 03:00:53 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0774.html

Note You need to log in before you can comment on or make changes to this bug.