Bug 812912
| Summary: | NPE in InventoryManager during detection of drift support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Heiko W. Rupp <hrupp> | ||||
| Component: | drift | Assignee: | Heiko W. Rupp <hrupp> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 4.3 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | RHQ 4.4.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-09-01 10:15:47 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 782759 | ||||||
| Attachments: |
|
||||||
Created attachment 577732 [details]
Screenshot of idea with some variables
as fix: return false if type==null as ignored resources have no drift support by definition Heiko is working on the fix master f383f2dc3a3f6eb Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since. |
The following code throws a NPE because type is null private boolean supportsDriftManagement(Resource r) { PluginMetadataManager metaDataMgr = PluginContainer.getInstance().getPluginManager().getMetadataManager(); ResourceType type = metaDataMgr.getType(r.getResourceType()); return type.getDriftDefinitionTemplates() != null && !type.getDriftDefinitionTemplates().isEmpty(); The resource in question is Resource[id=10004, uuid=192fc673-144a-4476-9e19-9b5166cc4193, type={Samba}Samba Server, key=/etc/samba/smb.conf, name=pintsize.home.pilhuhn.de, parent=pintsize] where r.inventoryStatus == IGNORED Agent log says 2012-04-16 16:41:43,313 WARN [InventoryManager.discovery-1] (rhq.core.pc.inventory.InventoryManager)- Failed to synchronize local inventory with Server inventory for Resource [10001] and its descendants: null