Bug 812912 - NPE in InventoryManager during detection of drift support
Summary: NPE in InventoryManager during detection of drift support
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: drift
Version: 4.3
Hardware: Unspecified
OS: Unspecified
high
urgent vote
Target Milestone: ---
: RHQ 4.4.0
Assignee: Heiko W. Rupp
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: 782759
TreeView+ depends on / blocked
 
Reported: 2012-04-16 14:42 UTC by Heiko W. Rupp
Modified: 2013-09-01 10:15 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-09-01 10:15:47 UTC


Attachments (Terms of Use)
Screenshot of idea with some variables (121.71 KB, image/png)
2012-04-16 14:43 UTC, Heiko W. Rupp
no flags Details

Description Heiko W. Rupp 2012-04-16 14:42:32 UTC
The following code throws a NPE because type is null

    private boolean supportsDriftManagement(Resource r) {
        PluginMetadataManager metaDataMgr = PluginContainer.getInstance().getPluginManager().getMetadataManager();
        ResourceType type = metaDataMgr.getType(r.getResourceType());
        return type.getDriftDefinitionTemplates() != null && !type.getDriftDefinitionTemplates().isEmpty();

The  resource in question is 

Resource[id=10004, uuid=192fc673-144a-4476-9e19-9b5166cc4193, type={Samba}Samba Server, key=/etc/samba/smb.conf, name=pintsize.home.pilhuhn.de, parent=pintsize]

where r.inventoryStatus == IGNORED

Agent log says 

2012-04-16 16:41:43,313 WARN  [InventoryManager.discovery-1] (rhq.core.pc.inventory.InventoryManager)- Failed to synchronize local inventory with Server inventory for Resource [10001] and its descendants: null

Comment 1 Heiko W. Rupp 2012-04-16 14:43:06 UTC
Created attachment 577732 [details]
Screenshot of idea with some variables

Comment 2 Heiko W. Rupp 2012-04-16 14:57:54 UTC
as fix: return false if type==null as ignored resources have no drift support by definition

Comment 3 Charles Crouch 2012-04-16 15:40:56 UTC
Heiko is working on the fix

Comment 4 Heiko W. Rupp 2012-04-16 15:44:47 UTC
master  f383f2dc3a3f6eb

Comment 5 Heiko W. Rupp 2013-09-01 10:15:47 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.


Note You need to log in before you can comment on or make changes to this bug.