Bug 820663

Summary: update of Finance::Quote
Product: [Fedora] Fedora Reporter: Marcela Mašláňová <mmaslano>
Component: perl-Finance-QuoteAssignee: Bill Nottingham <notting>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: amessina, anton, centaur, dwmw2, extras-qa, mark, notting, perl-devel, redhat-bugzilla, rtc, rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-Finance-Quote-1.20-3.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-26 13:53:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2012-05-10 15:36:00 UTC
I was asked to rebase this package to the latest upstream version. There are no new releases on cpan, but they are on github:
https://github.com/pfenwick/finance-quote

Also SUSE has quite few new patches:
https://build.opensuse.org/package/files?package=perl-Finance-Quote&project=devel%3Alanguages%3Aperl

Bill, I'm quite surprised that you are the maintainer of Perl package. If you want to get rid of it, someone from Perl SIG could take it.

Thanks.

Comment 1 Bill Nottingham 2012-05-11 21:13:18 UTC
I maintain it b/c I own the only thing that uses it (GnuCash).

SuSE had contacted me about joining their package as the 'new' upstream source a while back, I just hadn't gotten around to switching it yet. AFAIK, the github mentioned hasn't really been updated much.

Comment 2 Marcela Mašláňová 2012-05-16 09:19:49 UTC
The latest upstream is not same as SUSE. I'm looking at their patches and the most life upstream on github. 

The problem are failing test suites. It looks like no one was running them or no one was trying them with latest Perl. I'll try to fix it and contact github developer.

Comment 3 Peter Lawler 2012-07-26 01:13:22 UTC
Would this be a duplicate of #807072?

Comment 4 Marcela Mašláňová 2012-07-26 07:26:08 UTC
It might be.

I was looking on a new upstream git, which had less failures https://github.com/pfenwick/finance-quote ,but some tests are still failling and some patches are different or missing. If you are willing to test it, it would help. I'd rather don't broke currently working things.

Comment 5 Marcela Mašláňová 2012-07-27 11:48:59 UTC
Ok, I finally prepared srpm. Peter would you mind to test it with gnucash? I'm not using it.
My version is snapshot from the upstream github and few patches from Debian and few from OpenSUSE. It seems to me some online tests are working just sometimes. Some tests stopped working (financecanada), but they didn't work well even before.

http://mmaslano.fedorapeople.org/bugy/perl-Finance-Quote-1.17-10.20120515git811c96.fc18.src.rpm

Comment 6 Bill Nottingham 2012-07-27 14:14:56 UTC
Marcela - do you want to apply for comaintainership? I can give perl-sig commit access in pkgdb, but I don't know if that accomplishes anything as that's not a user account.

Comment 7 Peter Lawler 2012-07-28 22:49:13 UTC
Marcela: You're right! The tests, they fail a little bit ;)
Files=52, Tests=728
...
Failed 24/52 test programs. 267/728 subtests failed.

Even with disabling the tests, the function still doesn't seem to work for me, but maybe that's because of AUD the errors (my default currency)

Comment 8 Marcela Mašláňová 2012-07-30 10:51:55 UTC
(In reply to comment #6)
> Marcela - do you want to apply for comaintainership? I can give perl-sig
> commit access in pkgdb, but I don't know if that accomplishes anything as
> that's not a user account.

Bill, I'm a provenpackager, but I can be even comaintainer. The SIG group doesn't work for commits, it's currently used only for CC'ing all bugzillas.

Comment 9 Marcela Mašláňová 2012-07-31 12:24:09 UTC
(In reply to comment #7)
> Marcela: You're right! The tests, they fail a little bit ;)
> Files=52, Tests=728
> ...
> Failed 24/52 test programs. 267/728 subtests failed.
> 
> Even with disabling the tests, the function still doesn't seem to work for
> me, but maybe that's because of AUD the errors (my default currency)

I looked on those online failing tests and they are failing less than before or they didn't work properly even before.
Try this srpm: http://mmaslano.fedorapeople.org/bugy/perl-Finance-Quote-1.17-10.20120515git811c96.fc16.src.rpm

I've added patches, which were mentioned in Debian. They fixed issues for more than one currency if I understand German ;-)

Comment 10 Anton Arapov 2012-10-24 09:31:40 UTC
*** Bug 807072 has been marked as a duplicate of this bug. ***

Comment 11 Anton Arapov 2012-10-24 09:34:00 UTC
Please, would you spin an update to version 1.18 that was released back in September 30. It should fix this issue as well, and as affected person I'd be glad to test it. :)

"
http://finance-quote.sourceforge.net/
2012-Sep-30 Release 1.18 is available both from CPAN and Sourveforge. It solves most used module errors.
"

thanks,
Anton

Comment 12 Marcela Mašláňová 2012-10-24 16:39:12 UTC
Hm, I need to review ~20 patches if they are sort of in.

Comment 13 Fedora End Of Life 2013-04-03 16:30:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 14 Peter Backes 2013-06-10 19:42:22 UTC
*** Bug 972522 has been marked as a duplicate of this bug. ***

Comment 15 Peter Lawler 2014-01-05 20:59:25 UTC
Oh hey, I had forgotten about this bug until I updated to F20 and GnuCash was on the 'featured' list of the in-distro Software Installer.
Did Bill and Marcela sort out the comaint as referenced in #comment8?

Comment 16 Peter Lawler 2014-02-16 10:30:52 UTC
To answer myself in #comment15
---
Just got the update gnucash to 2.6.1, it continues to be unable to handle any currency apart from what one sets as default.

Checked perl-Finance-Quote's changelog,
* Sun Aug  4 22:00:00 2013 Petr Pisar <ppisar> - 1.17-13
- Perl 5.18 rebuild

I guess the answer to my question is no.

Kinda hoping this gets fixed for RHEL7 desktops. I can't do much apart from test, my Perl knowledge died sometime late last century. But I can offer to help.

Paul Fenwick's repository has moved to https://github.com/pjf/finance-quote And there have been recent updates there. OpenSUSE seem to have moved their URLs around too, not too sure what I'm looking at there. Might see what I can hack together next weekend, no promises. Any tips/advice welcome though :)

Comment 17 Bill Nottingham 2014-02-17 04:28:36 UTC
There's a 1.19 release very recently due to Yahoo breaking.... I'll get that pulled in shortly where appropriate.

Comment 18 Fedora Update System 2014-02-17 17:03:02 UTC
perl-Finance-Quote-1.20-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Finance-Quote-1.20-1.fc19

Comment 19 Fedora Update System 2014-02-17 17:05:29 UTC
perl-Finance-Quote-1.20-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Finance-Quote-1.20-1.fc20

Comment 20 Fedora Update System 2014-02-17 17:23:08 UTC
perl-Finance-Quote-1.20-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Finance-Quote-1.20-1.el6

Comment 21 Peter Lawler 2014-02-17 19:35:01 UTC
Thanks, bloke. Grabbed the F20 from kojipkgs. WFM.

Comment 22 Fedora Update System 2014-02-18 13:42:09 UTC
Package perl-Finance-Quote-1.20-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Finance-Quote-1.20-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-2695/perl-Finance-Quote-1.20-1.fc20
then log in and leave karma (feedback).

Comment 23 Fedora Update System 2014-02-26 13:53:43 UTC
perl-Finance-Quote-1.20-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 24 Fedora Update System 2014-02-28 18:28:38 UTC
perl-Finance-Quote-1.20-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2014-03-17 05:58:31 UTC
perl-Finance-Quote-1.20-3.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.