Bug 821220
| Summary: | cxxtools - A collection of general-purpose C++ classes | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | MartinKG <mgansser> |
| Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, ville.skytta |
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-29 17:14:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 821224 | ||
|
Description
MartinKG
2012-05-13 08:46:40 UTC
Looks like 2.1.1 is available.
Run unit tests during build, e.g. like this between %install and %clean:
%check
test/alltests
URL should probably be http://www.tntnet.org/cxxtools.html
Be consistent with the Group tag, either add one for the main package or remove it from -devel too.
%{?_isa} missing from -devel's main package dep:
https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package
> # FIXME: really? re-check!
Please re-check the license and remove the above comment when done.
> https://sourceforge.net/tracker/
> ?func=detail&aid=3525604&group_id=124828&atid=700758
That's not a bug, just leave the file out from the package if it's empty.
SRPM URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools-2.1.1-1.fc17.src.rpm?a=w7DyN-YVNC0 Spec URL: https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools.spec?a=jFApyd75nmk rpmlint output: rpmlint cxxtools-2.1.1-1.fc17.src.rpm cxxtools.src: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint cxxtools-2.1.1-1.fc17.x86_64.rpm cxxtools.x86_64: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint cxxtools-debuginfo-2.1.1-1.fc17.x86_64.rpm cxxtools-debuginfo.x86_64: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint cxxtools-devel-2.1.1-1.fc17.x86_64.rpm cxxtools-devel.x86_64: I: enchant-dictionary-not-found en_US cxxtools-devel.x86_64: W: no-documentation cxxtools-devel.x86_64: W: no-manual-page-for-binary cxxtools-config 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Will look into this later, but please don't touch the status or assigned to fields between package revisions unless you want a new reviewer. As noted in bug 819237 comment 9, please also re-fix your rpmlint/enchant config and keep it fixed by installing the hunspell-en package. One common and useful practice between package revisions is to post the changelog after the previous release into the review bug. There's no need to repeatedly post the rpmlint output if it contains nothing of interest (such as in comment 2). Looks fine otherwise, but there's a bundled MD5 implementation in src/md5.c which looks like the Polstra one to me - if that's correct, should add: Provides: bundled(md5-polstra) See https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries for more info. Approved - no need to submit a new package here just to fix this if you don't want, but please be sure to fix it before the first build you submit to koji. %changelog * Mon May 28 2012 Martin Gansser <linux4martin> - 2.1.1-2 - added Provides: bundled(md5-polstra) New Package SCM Request ======================= Package Name: cxxtools Short Description: A collection of general-purpose C++ classes Owners: martinkg Branches: f16 f17 InitialCC: Remember to set the fedora-cvs flag whenever making SCM requests... Git done (by process-git-requests). the package built successfully on koji fc18-candidate: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112594 f17-candidate: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112762 f16-candidate: Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112807 cxxtools-2.1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/cxxtools-2.1.1-2.fc17 cxxtools-2.1.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/cxxtools-2.1.1-2.fc16 Both updates for F17 and F16 are still "pending", so they are not available and won't be published ever. You need to request a push to "testing". cxxtools was pushed to testing http://dl.fedoraproject.org/pub/fedora/linux/updates/testing/17/x86_64/ cxxtools-2.1.1-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. cxxtools-2.1.1-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: cxxtools New Branches: f18 Owners: martinkg InitialCC: f18 branch exists. cxxtools-2.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cxxtools-2.2-1.fc18 cxxtools-2.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/cxxtools-2.2-1.fc19 No need to reference this bug in updates, the package has been in the repos for a long time already. Package Change Request ====================== Package Name: cxxtools New Branches: fc23 devel Owners: martinkg InitialCC: [please untire cxxtools, because package vdr-lieve depends on it] This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests. |