Bug 821220 - cxxtools - A collection of general-purpose C++ classes
Summary: cxxtools - A collection of general-purpose C++ classes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 821224
TreeView+ depends on / blocked
 
Reported: 2012-05-13 08:46 UTC by MartinKG
Modified: 2015-10-06 20:13 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-05-29 17:14:29 UTC
Type: Bug
Embargoed:
ville.skytta: fedora-review+


Attachments (Terms of Use)

Description MartinKG 2012-05-13 08:46:40 UTC
cxtools, a collection of general-purpose C++ classes, needed for vdr-live VDR plugin.

Bugreport updstream: zero-length /usr/share/doc/cxxtools-2.1/NEWS
# https://sourceforge.net/tracker/?func=detail&aid=3525604&group_id=124828&atid=700758

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools.spec?a=PEmZuKi-5zo

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools-2.1-1.fc17.src.rpm?a=fTtipN_hwwk

rpmlint output:

rpmlint cxxtools-2.1-1.fc17.src.rpm
cxxtools.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-2.1-1.fc17.x86_64.rpm
cxxtools.x86_64: I: enchant-dictionary-not-found en_US
cxxtools.x86_64: E: zero-length /usr/share/doc/cxxtools-2.1/NEWS
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

Comment 1 Ville Skyttä 2012-05-25 19:44:30 UTC
Looks like 2.1.1 is available.

Run unit tests during build, e.g. like this between %install and %clean:
    %check
    test/alltests

URL should probably be http://www.tntnet.org/cxxtools.html

Be consistent with the Group tag, either add one for the main package or remove it from -devel too.

%{?_isa} missing from -devel's main package dep:
https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package

> # FIXME: really? re-check!

Please re-check the license and remove the above comment when done.

> https://sourceforge.net/tracker/
> ?func=detail&aid=3525604&group_id=124828&atid=700758

That's not a bug, just leave the file out from the package if it's empty.

Comment 2 MartinKG 2012-05-26 11:39:50 UTC
SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools-2.1.1-1.fc17.src.rpm?a=w7DyN-YVNC0

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/cxxtools/cxxtools.spec?a=jFApyd75nmk

rpmlint output:

rpmlint cxxtools-2.1.1-1.fc17.src.rpm
cxxtools.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-2.1.1-1.fc17.x86_64.rpm
cxxtools.x86_64: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-debuginfo-2.1.1-1.fc17.x86_64.rpm
cxxtools-debuginfo.x86_64: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-devel-2.1.1-1.fc17.x86_64.rpm
cxxtools-devel.x86_64: I: enchant-dictionary-not-found en_US
cxxtools-devel.x86_64: W: no-documentation
cxxtools-devel.x86_64: W: no-manual-page-for-binary cxxtools-config
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 3 Ville Skyttä 2012-05-26 17:19:11 UTC
Will look into this later, but please don't touch the status or assigned to fields between package revisions unless you want a new reviewer.

As noted in bug 819237 comment 9, please also re-fix your rpmlint/enchant config and keep it fixed by installing the hunspell-en package.

One common and useful practice between package revisions is to post the changelog after the previous release into the review bug.  There's no need to repeatedly post the rpmlint output if it contains nothing of interest (such as in comment 2).

Comment 4 Ville Skyttä 2012-05-28 19:31:27 UTC
Looks fine otherwise, but there's a bundled MD5 implementation in src/md5.c which looks like the Polstra one to me - if that's correct, should add:

   Provides: bundled(md5-polstra)

See https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries for more info.

Approved - no need to submit a new package here just to fix this if you don't want, but please be sure to fix it before the first build you submit to koji.

Comment 5 MartinKG 2012-05-28 20:01:58 UTC
%changelog
* Mon May 28 2012 Martin Gansser <linux4martin> - 2.1.1-2
- added Provides: bundled(md5-polstra)


New Package SCM Request
=======================
Package Name: cxxtools
Short Description: A collection of general-purpose C++ classes
Owners: martinkg
Branches: f16 f17
InitialCC:

Comment 6 Ville Skyttä 2012-05-28 21:59:54 UTC
Remember to set the fedora-cvs flag whenever making SCM requests...

Comment 7 Gwyn Ciesla 2012-05-29 12:41:30 UTC
Git done (by process-git-requests).

Comment 8 MartinKG 2012-05-29 17:14:29 UTC
the package built successfully on koji

fc18-candidate:
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112594

f17-candidate: 
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112762

f16-candidate:
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4112807

Comment 9 Fedora Update System 2012-05-29 17:34:43 UTC
cxxtools-2.1.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/cxxtools-2.1.1-2.fc17

Comment 10 Fedora Update System 2012-05-29 17:36:40 UTC
cxxtools-2.1.1-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/cxxtools-2.1.1-2.fc16

Comment 11 Michael Schwendt 2012-06-17 18:15:45 UTC
Both updates for F17 and F16 are still "pending", so they are not available and won't be published ever. You need to request a push to "testing".

Comment 12 MartinKG 2012-06-19 16:23:27 UTC
cxxtools was pushed to testing
http://dl.fedoraproject.org/pub/fedora/linux/updates/testing/17/x86_64/

Comment 13 Fedora Update System 2012-06-28 03:29:57 UTC
cxxtools-2.1.1-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2012-06-28 03:54:07 UTC
cxxtools-2.1.1-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 MartinKG 2012-10-18 18:37:05 UTC
Package Change Request
======================
Package Name: cxxtools
New Branches: f18
Owners: martinkg
InitialCC:

Comment 16 Gwyn Ciesla 2012-10-18 18:49:16 UTC
f18 branch exists.

Comment 17 Fedora Update System 2013-05-03 21:33:04 UTC
cxxtools-2.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/cxxtools-2.2-1.fc18

Comment 18 Fedora Update System 2013-05-03 21:33:18 UTC
cxxtools-2.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cxxtools-2.2-1.fc19

Comment 19 Ville Skyttä 2013-05-04 08:11:12 UTC
No need to reference this bug in updates, the package has been in the repos for a long time already.

Comment 20 MartinKG 2015-10-06 19:13:43 UTC
Package Change Request
======================
Package Name: cxxtools
New Branches: fc23 devel
Owners: martinkg
InitialCC: 

[please untire cxxtools, because package vdr-lieve depends on it]

Comment 21 Gwyn Ciesla 2015-10-06 20:13:37 UTC
This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.


Note You need to log in before you can comment on or make changes to this bug.