Bug 822294

Summary:	Review Request: stlink - tools for stm32 discovery boards
Product:	[Fedora] Fedora	Reporter:	Rob Gilton <rob>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	james.hogarth, package-review, rob
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-04 04:37:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Rob Gilton 2012-05-17 00:44:26 UTC

Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec
SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-20120517gitd2c78.fc16.src.rpm
Description: stlink is a set of tools for interacting with the STM32 discovery
boards.  It includes a program that acts as a gdbserver, and a tool
for reading/writing/erasing the flash of the target on the boards.

A review would be much appreciated :-)

Comment 1 Rob Gilton 2012-05-17 00:47:56 UTC

Whoops, forgot the rpmlint output!  Here it is:

stlink.spec: W: invalid-url Source0: stlink-d2c78.tar.bz2
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

It's an invalid URL because it's a git snapshot.  No way around that one.

Comment 2 Rob Gilton 2012-05-17 01:00:38 UTC

Now updated to include the AUTHORS and COPYING files:

New SRPM: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-1.20120517gitd2c78.fc16.src.rpm
Specfile: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec

Cheers.

Comment 3 Jason Tibbitts 2013-05-21 00:48:57 UTC

I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

Unfortunately I have no way at all to even test this, and I suspect the other prospective reviewers are in the same boat.  It's quite a simple package, though; on a quick inspection I can only see two issues:

We have guidelines relating to packaging tarballs from github, which you should follow instead of just saying that you generated a snapshot from git.  http://fedoraproject.org/wiki/Packaging:SourceURL#Github

There is no need to clean the buildroot at the beginning of %install.

Comment 4 James Hogarth 2015-12-04 04:37:38 UTC

As per the policy for stalled reviews closing this ticket as the requester has not responded to a needs info in over a year

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews