Bug 822294 - Review Request: stlink - tools for stm32 discovery boards
Review Request: stlink - tools for stm32 discovery boards
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2012-05-16 20:44 EDT by Rob Spanton
Modified: 2015-12-03 23:37 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-12-03 23:37:38 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Rob Spanton 2012-05-16 20:44:26 EDT
Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec
SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-20120517gitd2c78.fc16.src.rpm
Description: stlink is a set of tools for interacting with the STM32 discovery
boards.  It includes a program that acts as a gdbserver, and a tool
for reading/writing/erasing the flash of the target on the boards.

A review would be much appreciated :-)
Comment 1 Rob Spanton 2012-05-16 20:47:56 EDT
Whoops, forgot the rpmlint output!  Here it is:

stlink.spec: W: invalid-url Source0: stlink-d2c78.tar.bz2
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

It's an invalid URL because it's a git snapshot.  No way around that one.
Comment 2 Rob Spanton 2012-05-16 21:00:38 EDT
Now updated to include the AUTHORS and COPYING files:

New SRPM: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-1.20120517gitd2c78.fc16.src.rpm
Specfile: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec

Cheers.
Comment 3 Jason Tibbitts 2013-05-20 20:48:57 EDT
I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

Unfortunately I have no way at all to even test this, and I suspect the other prospective reviewers are in the same boat.  It's quite a simple package, though; on a quick inspection I can only see two issues:

We have guidelines relating to packaging tarballs from github, which you should follow instead of just saying that you generated a snapshot from git.  http://fedoraproject.org/wiki/Packaging:SourceURL#Github

There is no need to clean the buildroot at the beginning of %install.
Comment 4 James Hogarth 2015-12-03 23:37:38 EST
As per the policy for stalled reviews closing this ticket as the requester has not responded to a needs info in over a year

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

Note You need to log in before you can comment on or make changes to this bug.