Red Hat Bugzilla – Bug 822294
Review Request: stlink - tools for stm32 discovery boards
Last modified: 2015-12-03 23:37:38 EST
Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec
SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-20120517gitd2c78.fc16.src.rpm
Description: stlink is a set of tools for interacting with the STM32 discovery
boards. It includes a program that acts as a gdbserver, and a tool
for reading/writing/erasing the flash of the target on the boards.
A review would be much appreciated :-)
Whoops, forgot the rpmlint output! Here it is:
stlink.spec: W: invalid-url Source0: stlink-d2c78.tar.bz2
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
It's an invalid URL because it's a git snapshot. No way around that one.
Now updated to include the AUTHORS and COPYING files:
New SRPM: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-1.20120517gitd2c78.fc16.src.rpm
I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.
Unfortunately I have no way at all to even test this, and I suspect the other prospective reviewers are in the same boat. It's quite a simple package, though; on a quick inspection I can only see two issues:
We have guidelines relating to packaging tarballs from github, which you should follow instead of just saying that you generated a snapshot from git. http://fedoraproject.org/wiki/Packaging:SourceURL#Github
There is no need to clean the buildroot at the beginning of %install.
As per the policy for stalled reviews closing this ticket as the requester has not responded to a needs info in over a year