Bug 822507

Summary:	Attribute unique in XML metadata
Product:	Red Hat Enterprise Linux 6	Reporter:	Nate Straz <nstraz>
Component:	fence-agents	Assignee:	Marek Grac <mgrac>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.3	CC:	cluster-maint, djansa, dyasny, jpokorny, mgrac, mjuricek, slevine
Target Milestone:	rc	Keywords:	EasyFix
Target Release:	6.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	fence-agents-3.1.5-20.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	806883	Environment:
Last Closed:	2013-02-21 07:41:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	806883
Bug Blocks:

Description Nate Straz 2012-05-17 14:44:43 UTC

+++ This bug was initially created as a clone of Bug #806883 +++

Cloned to fix agents missed in 6.3.

Attribute unique in XML metadata (-o metadata) is set to TRUE (1) by default in all of the cases. "Unique" should be used only in situation where same value cannot be used across several agents. Fence agents do not have such kind of attributes so default value should be FALSE (0).

--- Additional comment from mgrac on 2012-03-26 08:40:06 EDT ---

Fixed in upstream:

http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=aefb817f08bfa8f2f1b1c1270ad4d697649fa40c

--- Additional comment from nstraz on 2012-05-17 10:10:08 EDT ---

I looked through the metadata generated by all fence agents and found the following agents still produce unique parameters

fence_brocade
fence_drac
fence_egenera
fence_kdump
fence_scsi

Should these fence agents be fixed too?

Comment 1 Marek Grac 2012-05-21 08:18:37 UTC

Fix is now in upstream:

http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=87cbe09e06ce8a5fb578cffe21b3d2137d5f0e17

Comment 4 Marek Grac 2012-10-25 08:55:48 UTC

Unit test:

./fence_? -o metadata | grep unique 

<parameter name="action" unique="0" required="1">
<parameter name="ipaddr" unique="0" required="1">
..

there should be no answer for 

./fence_? -o metadata | grep 'unique="1"'

Comment 7 errata-xmlrpc 2013-02-21 07:41:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0286.html

Comment 8 Jan Pokorný [poki] 2013-09-19 19:56:08 UTC

Note that unique="0" could be omitted algotgether: [1,2]

[1] https://github.com/ClusterLabs/resource-agents/blob/master/heartbeat/ra-api-1.dtd#L18
[2] https://github.com/ClusterLabs/resource-agents/blob/master/rgmanager/src/resources/ra-api-1-modified.dtd#L28