Red Hat Bugzilla – Bug 822507
Attribute unique in XML metadata
Last modified: 2013-09-19 15:56:08 EDT
+++ This bug was initially created as a clone of Bug #806883 +++ Cloned to fix agents missed in 6.3. Attribute unique in XML metadata (-o metadata) is set to TRUE (1) by default in all of the cases. "Unique" should be used only in situation where same value cannot be used across several agents. Fence agents do not have such kind of attributes so default value should be FALSE (0). --- Additional comment from mgrac@redhat.com on 2012-03-26 08:40:06 EDT --- Fixed in upstream: http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=aefb817f08bfa8f2f1b1c1270ad4d697649fa40c --- Additional comment from nstraz@redhat.com on 2012-05-17 10:10:08 EDT --- I looked through the metadata generated by all fence agents and found the following agents still produce unique parameters fence_brocade fence_drac fence_egenera fence_kdump fence_scsi Should these fence agents be fixed too?
Fix is now in upstream: http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=87cbe09e06ce8a5fb578cffe21b3d2137d5f0e17
Unit test: ./fence_? -o metadata | grep unique <parameter name="action" unique="0" required="1"> <parameter name="ipaddr" unique="0" required="1"> .. there should be no answer for ./fence_? -o metadata | grep 'unique="1"'
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0286.html
Note that unique="0" could be omitted algotgether: [1,2] [1] https://github.com/ClusterLabs/resource-agents/blob/master/heartbeat/ra-api-1.dtd#L18 [2] https://github.com/ClusterLabs/resource-agents/blob/master/rgmanager/src/resources/ra-api-1-modified.dtd#L28