Bug 823054
| Summary: | Review Request: php-symfony2-HttpFoundation - Symfony2 HttpFoundation Component | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-06-26 21:31:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 814994 | ||||||
| Bug Blocks: | 823066, 823071, 823073, 823075 | ||||||
| Attachments: |
|
||||||
|
Description
Shawn Iwinski
2012-05-18 21:36:17 UTC
Updates per comments in bug 823043 - Removed BuildRoot - Changed php require to php-common - Added the following requires based on phpci results: php-date, php-fileinfo, php-hash, php-pcre, php-session, php-sockets, php-spl - Removed %defattr from %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation-2.0.14-2.fc16.src.rpm Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5 - Moved documentation to correct location SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation-2.0.14-3.fc16.src.rpm Updated to upstream version 2.0.15 & updates per bug #817303 - Removed "BuildRequires: php-pear >= 1:1.4.9-1.2" - Updated %prep section - Removed cleaning buildroot from %install section - Removed documentation move from %install section (fixed upstream) - Removed %clean section - Updated %doc in %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation-2.0.15-1.fc16.src.rpm Created attachment 590698 [details]
php-symfony2-HttpFoundation-review.txt
Generated by fedora-review 0.1.3
In Symfony\Component\HttpFoundation\SessionStorage\PdoSessionStorage public function __construct(\PDO $db, array $options = array(), array $dbOptions = array()) You, you need to add "php-do" in dependency list (this is not detected by phpci, I will report a bug upstream) (In reply to comment #5) > You, you need to add "php-do" in dependency list Thanks Remi. I will add the "php-pdo" require after the approved import. (In reply to comment #6) > (In reply to comment #5) > > You, you need to add "php-do" in dependency list > > Thanks Remi. I will add the "php-pdo" require after the approved import. Never mind! This package is not approved yet. I will make the change and post the new spec and SRPM. Small note:
Extension dependencies should be described in the package.xml
You can report this to upstream with the result of your analysis.
ex :
<dependencies>
<required>
<extension>
<name>spl</name>
</extension>
</required>
<optional>
<extension>
<name>tokenizer</name>
</extension>
</optional>
</dependencies>
pear make-rpm-spec doesn't handle this for now... one more think in my TODO list...
(In reply to comment #8) > Extension dependencies should be described in the package.xml > You can report this to upstream with the result of your analysis. Thanks Remi. I will work with upstream on this. Updated per comment #5 - Added php-pdo require SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpFoundation.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpFoundation-2.0.15-2.fc17.src.rpm $ diff php-symfony2-HttpFoundation.spec.1 php-symfony2-HttpFoundation.spec
7c7
< Release: 1%{?dist}
---
> Release: 2%{?dist}
23a24
> Requires: php-pdo
88a90,92
> * Mon Jun 11 2012 Shawn Iwinski <shawn.iwinski> 2.0.15-2
> - Added php-pdo require
Blocker fixed
== Approved ==
New Package SCM Request ======================= Package Name: php-symfony2-HttpFoundation Short Description: Symfony2 HttpFoundation Component Owners: siwinski Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). php-symfony2-HttpFoundation-2.0.15-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2.fc17 php-symfony2-HttpFoundation-2.0.15-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2.fc16 php-symfony2-HttpFoundation-2.0.15-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony2-HttpFoundation-2.0.15-2.el6 php-symfony2-HttpFoundation-2.0.15-2.fc16 has been pushed to the Fedora 16 testing repository. php-symfony2-HttpFoundation-2.0.15-2.fc17 has been pushed to the Fedora 17 stable repository. php-symfony2-HttpFoundation-2.0.15-2.fc16 has been pushed to the Fedora 16 stable repository. php-symfony2-HttpFoundation-2.0.15-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |