Bug 823331
| Summary: | Review Request: rubygem-mixlib-authentication - Ruby class-based header signing authentication object | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonas Courteau <rpms> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hhorak, jdunn, jstribny, notting, package-review |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-02 04:18:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 823332 | ||
| Bug Blocks: | 823344, 823352 | ||
|
Description
Jonas Courteau
2012-05-20 23:38:03 UTC
* There is a newer upstream version that most likely does not need patching [1]
* Requires: ruby should be dropped to support more implementations of Ruby in f19
* Please consider moving specs into the -doc subpackage rather than exclude them
* README.rdoc and NOTICE could be part of the -doc subpackage as they are not
needed at runtime and marked as %doc
* I would suggest you to exclude %{gem_cache} as it's not needed
Because this gem requires rubygem-mixlib-log, I am adding related depends on.
@Julian C. Dunn: I am adding you to CC, because you showed interest in packing rubygem-chef (#823352).
I am sorry, I forgot the link: [1] http://rubygems.org/gems/mixlib-authentication/versions/1.3.0 Thanks Josef, I have made these changes and upgraded to 1.3.0. Please see here: http://jdunn.fedorapeople.org/rubygem-mixlib-authentication/rubygem-mixlib-authentication.spec http://jdunn.fedorapeople.org/rubygem-mixlib-authentication/rubygem-mixlib-authentication-1.3.0-1.fc19.src.rpm * Don't use %exclude on files you are listing in subpackages
- Delete %exclude %{gem_instdir}/spec
* README.rdoc and NOTICE should be marked as %doc
Otherwise the spec file looks good, it builds in Koji and rpmlint gives me no errors so I am APPROVING it. Please fix issues above before pushing.
New Package SCM Request ======================= Package Name: rubygem-mixlib-authentication Short Description: Ruby class-based header signing authentication object Owners: jdunn Branches: f17 f18 el6 InitialCC: Unretired, submit a Package Change request for new branches. Package Change Request ====================== Package Name: rubygem-mixlib-authentication New Branches: f17 f18 Owners: Git done (by process-git-requests). rubygem-mixlib-authentication-1.3.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-authentication-1.3.0-2.fc18 rubygem-mixlib-authentication-1.3.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-authentication-1.3.0-2.fc17 rubygem-mixlib-authentication-1.3.0-2.fc18 has been pushed to the Fedora 18 testing repository. rubygem-mixlib-authentication-1.3.0-2.fc17 has been pushed to the Fedora 17 stable repository. rubygem-mixlib-authentication-1.3.0-2.fc18 has been pushed to the Fedora 18 stable repository. |