Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-mixlib-log/rubygem-mixlib-log.spec SRPM URL: http://rpms.courteau.org/fedora/rubygem-mixlib-log-1.3.0-1.fc17.src.rpm Description: A gem that provides a simple mixin for log functionality. This is part of a set of dependencies for rubygem-chef. I've got about 14 packages to add, all ruby gems, and am looking for a sponsor. Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
* There is a newer upstream version out [1]. In Fedora we try to stay with the latest upstream version when possible. * Specs should be included in the -doc subpackage Note: specs are already included in the latest version of the gem [1] * %check section should ran also other specs that come with the 1.4.1 * The Ruby runtime dependency needs to be dropped in order to support multiple Ruby implementations in Fedora 19 - delete Requires: ruby [1] http://rubygems.org/gems/mixlib-log/versions/1.4.1
(In reply to comment #1) > * There is a newer upstream version out [1]. In Fedora we try to stay with > the > latest upstream version when possible. > > * Specs should be included in the -doc subpackage > Note: specs are already included in the latest version of the gem [1] > > * %check section should ran also other specs that come with the 1.4.1 > > * The Ruby runtime dependency needs to be dropped in order to support > multiple > Ruby implementations in Fedora 19 > - delete Requires: ruby > > [1] http://rubygems.org/gems/mixlib-log/versions/1.4.1 All done. Please see here for updated spec and SRPM: http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log.spec http://jdunn.fedorapeople.org/rubygem-mixlib-log/rubygem-mixlib-log-1.4.1-1.fc19.src.rpm I had some issues getting the conditional macro to work in %check for EL6 (rspec is too old on EL6 to run the tests). What's in the spec now works, but it's ugly. Ideally I would just like to do something like %if %{!?el6} # run tests in here %endif but that didn't work.
Thank you Julian. * There is no need to exclude %{gem_instdir}/spec if you are listing it later in %files doc. -- Leave the file in the %files doc section and remove the exclusion of the file in %files * Files README.rdoc and NOTICE could be probably placed in the -doc subpackage as they are not needed for runtime. -- Please consider moving them to the -doc subpackage * Additionally, you can consider keeping Rakefile in the -doc subpackage as well. Otherwise it looks good. Rpmlint gave me no errors and the package builds in Koji so I am APPROVING the package. Please fix the issues before pushing.
Will do, thanks for the review, Josef.
Package Change Request ====================== Package Name: rubygem-mixlib-log New Branches: f16 f17 f18 Owners: jdunn InitialCC: Undeprecate package.
Git done (by process-git-requests).
rubygem-mixlib-log-1.4.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc18
rubygem-mixlib-log-1.4.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc17
rubygem-mixlib-log-1.4.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-mixlib-log-1.4.1-3.fc16
rubygem-mixlib-log-1.4.1-3.fc17 has been pushed to the Fedora 17 testing repository.
rubygem-mixlib-log-1.4.1-3.fc17 has been pushed to the Fedora 17 stable repository.
rubygem-mixlib-log-1.4.1-3.fc16 has been pushed to the Fedora 16 stable repository.
rubygem-mixlib-log-1.4.1-3.fc18 has been pushed to the Fedora 18 stable repository.