Bug 823331 - Review Request: rubygem-mixlib-authentication - Ruby class-based header signing authentication object
Review Request: rubygem-mixlib-authentication - Ruby class-based header signi...
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Josef Stribny
Fedora Extras Quality Assurance
:
Depends On: 823332
Blocks: 823344 823352
  Show dependency treegraph
 
Reported: 2012-05-20 19:38 EDT by Jonas Courteau
Modified: 2016-01-04 00:50 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2013-02-01 23:18:08 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jstribny: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jonas Courteau 2012-05-20 19:38:03 EDT
Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-mixlib-authentication/rubygem-mixlib-authentication.spec
SRPM URL:  http://rpms.courteau.org/fedora/rubygem-mixlib-authentication-1.1.4-1.fc17.src.rpm
Patches: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-mixlib-authentication/rubygem-mixlib-authentication-1.1.4-spec.patch

Depends on another package I've submitted - rubygem-mixlib-log

a Ruby class-based header signing authentication object.

This is part of a set of dependencies for rubygem-chef (see my other tickets for the rest).  I've got about 14 packages to add, all ruby gems, and am looking for a sponsor.  Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
Comment 1 Josef Stribny 2012-12-14 08:30:05 EST
* There is a newer upstream version that most likely does not need patching [1]

* Requires: ruby should be dropped to support more implementations of Ruby in f19

* Please consider moving specs into the -doc subpackage rather than exclude them

* README.rdoc and NOTICE could be part of the -doc subpackage as they are not 
  needed at runtime and marked as %doc

* I would suggest you to exclude %{gem_cache} as it's not needed

Because this gem requires rubygem-mixlib-log, I am adding related depends on.

@Julian C. Dunn: I am adding you to CC, because you showed interest in packing rubygem-chef (#823352).
Comment 2 Josef Stribny 2012-12-14 08:31:46 EST
I am sorry, I forgot the link:

[1] http://rubygems.org/gems/mixlib-authentication/versions/1.3.0
Comment 4 Josef Stribny 2013-01-17 11:19:24 EST
* Don't use %exclude on files you are listing in subpackages
  - Delete %exclude %{gem_instdir}/spec

* README.rdoc and NOTICE should be marked as %doc

Otherwise the spec file looks good, it builds in Koji and rpmlint gives me no errors so I am APPROVING it. Please fix issues above before pushing.
Comment 5 Julian C. Dunn 2013-01-17 11:57:48 EST
New Package SCM Request
=======================
Package Name: rubygem-mixlib-authentication
Short Description: Ruby class-based header signing authentication object
Owners: jdunn
Branches: f17 f18 el6
InitialCC:
Comment 6 Gwyn Ciesla 2013-01-17 12:19:57 EST
Unretired, submit a Package Change request for new branches.
Comment 7 Julian C. Dunn 2013-01-17 12:34:21 EST
Package Change Request
======================
Package Name: rubygem-mixlib-authentication
New Branches: f17 f18
Owners:
Comment 8 Gwyn Ciesla 2013-01-17 13:00:04 EST
Git done (by process-git-requests).
Comment 9 Fedora Update System 2013-01-23 10:52:39 EST
rubygem-mixlib-authentication-1.3.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-mixlib-authentication-1.3.0-2.fc18
Comment 10 Fedora Update System 2013-01-23 11:03:40 EST
rubygem-mixlib-authentication-1.3.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/rubygem-mixlib-authentication-1.3.0-2.fc17
Comment 11 Fedora Update System 2013-01-24 16:59:18 EST
rubygem-mixlib-authentication-1.3.0-2.fc18 has been pushed to the Fedora 18 testing repository.
Comment 12 Fedora Update System 2013-02-01 23:18:13 EST
rubygem-mixlib-authentication-1.3.0-2.fc17 has been pushed to the Fedora 17 stable repository.
Comment 13 Fedora Update System 2013-02-01 23:33:44 EST
rubygem-mixlib-authentication-1.3.0-2.fc18 has been pushed to the Fedora 18 stable repository.

Note You need to log in before you can comment on or make changes to this bug.