Bug 834512
| Summary: | Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, notting, package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-22 12:42:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 834516 | ||
|
Description
Jitka Plesnikova
2012-06-22 07:46:09 UTC
Source file is original. Ok.
Summary verified from lib/Data/HexDump/XXD.pm. Ok.
License verified from lib/Data/HexDump/XXD.pm. Ok.
Description verified from lib/Data/HexDump/XXD.pm. Ok.
URL and Source0 are usable. Ok.
TODO: You can remove the useless VERSION file from %doc
No XS code, noarch BuildArch is Ok.
TODO: You can remove cleaning the RPM_BUILD_ROOT from %install section. It's implicit.
Build-time dependencies are Ok.
All tests pass. Ok.
$ rpmlint perl-Data-HexDump-XXD.spec ../SRPMS/perl-Data-HexDump-XXD-0.1.0-1.fc18.src.rpm ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 Jun 22 13:21 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0
-rw-r--r-- 1 root root 160 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/Changes
-rw-r--r-- 1 root root 805 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/README
-rw-r--r-- 1 root root 134 Nov 12 2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/VERSION
-rw-r--r-- 1 root root 4842 Jun 22 13:21 /usr/share/man/man3/Data::HexDump::XXD.3pm.gz
drwxr-xr-x 2 root root 0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data
drwxr-xr-x 2 root root 0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump
-rw-r--r-- 1 root root 7490 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump/XXD.pm
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c
1 perl(base)
1 perl(Carp)
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(version)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c
1 perl(Data::HexDump::XXD)
1 perl-Data-HexDump-XXD = 0.1.0-1.fc18
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4187413). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED
New Package SCM Request ======================= Package Name: perl-Data-HexDump-XXD Short Description: Format hexadecimal dump like xxd Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. Package Change Request ====================== Package Name: perl-Data-HexDump-XXD New Branches: epel7 Owners: lkundrak The Fedora maintainer is unfortunately not maintaining EPEL packages: http://fedoraproject.org/wiki/EPEL/ContributorStatusNo Git done (by process-git-requests). |