Bug 834512 - Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
Review Request: perl-Data-HexDump-XXD - Format hexadecimal dump like xxd
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
Depends On:
Blocks: 834516
  Show dependency treegraph
Reported: 2012-06-22 03:46 EDT by Jitka Plesnikova
Modified: 2014-03-03 10:23 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-06-22 08:42:23 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2012-06-22 03:46:09 EDT
Spec URL: http://jplesnik.fedorapeople.org/perl-Data-HexDump-XXD/perl-Data-HexDump-XXD.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Data-HexDump-XXD/perl-Data-HexDump-XXD-0.1.0-1.fc18.src.rpm
Produce an hexadecimal dump like the program xxd would do, and do the reverse as well.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2012-06-22 07:29:01 EDT
Source file is original. Ok.
Summary verified from lib/Data/HexDump/XXD.pm. Ok.
License verified from lib/Data/HexDump/XXD.pm. Ok.
Description verified from lib/Data/HexDump/XXD.pm. Ok.
URL and Source0 are usable. Ok.

TODO: You can remove the useless VERSION file from %doc

No XS code, noarch BuildArch is Ok.

TODO: You can remove cleaning the RPM_BUILD_ROOT from %install section. It's implicit.

Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Data-HexDump-XXD.spec ../SRPMS/perl-Data-HexDump-XXD-0.1.0-1.fc18.src.rpm ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jun 22 13:21 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0
-rw-r--r--    1 root    root                      160 Nov 12  2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/Changes
-rw-r--r--    1 root    root                      805 Nov 12  2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/README
-rw-r--r--    1 root    root                      134 Nov 12  2007 /usr/share/doc/perl-Data-HexDump-XXD-0.1.0/VERSION
-rw-r--r--    1 root    root                     4842 Jun 22 13:21 /usr/share/man/man3/Data::HexDump::XXD.3pm.gz
drwxr-xr-x    2 root    root                        0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data
drwxr-xr-x    2 root    root                        0 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump
-rw-r--r--    1 root    root                     7490 Jun 22 13:21 /usr/share/perl5/vendor_perl/Data/HexDump/XXD.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(strict)
      1 perl(version)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Data::HexDump::XXD)
      1 perl-Data-HexDump-XXD = 0.1.0-1.fc18
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Data-HexDump-XXD-0.1.0-1.fc18.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4187413). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED
Comment 2 Jitka Plesnikova 2012-06-22 07:39:30 EDT
New Package SCM Request
Package Name: perl-Data-HexDump-XXD 
Short Description: Format hexadecimal dump like xxd
Owners: jplesnik mmaslano ppisar psabata
InitialCC: perl-sig
Comment 3 Gwyn Ciesla 2012-06-22 08:21:19 EDT
Git done (by process-git-requests).
Comment 4 Jitka Plesnikova 2012-06-22 08:42:23 EDT
Thank you for the review and the repository.
Comment 5 Lubomir Rintel 2014-03-03 09:55:42 EST
Package Change Request
Package Name: perl-Data-HexDump-XXD
New Branches: epel7
Owners: lkundrak

The Fedora maintainer is unfortunately not maintaining EPEL packages:
Comment 6 Gwyn Ciesla 2014-03-03 10:23:58 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.