Bug 834516 - Review Request: perl-Devel-StringInfo - Gather information about strings
Review Request: perl-Devel-StringInfo - Gather information about strings
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On: 834512
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-22 04:12 EDT by Jitka Plesnikova
Modified: 2014-03-03 10:24 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-06-22 10:42:02 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2012-06-22 04:12:07 EDT
Spec URL: http://jplesnik.fedorapeople.org/perl-Devel-StringInfo/perl-Devel-StringInfo.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Devel-StringInfo/perl-Devel-StringInfo-0.04-1.fc18.src.rpm
Description:
This module is a debugging aid that helps figure out more information about strings.

Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2012-06-22 09:13:09 EDT
Source file is original. Ok.
Summary verified from lib/Devel/StringInfo.pm.

FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).

Description verified from lib/Devel/StringInfo.pm. Ok.
No XS code, noarch BuildArch is Ok.
URL and Source0 are usable. Ok.
Build-requires are Ok.
All tests pass. Ok.

$ rpmlint  perl-Devel-StringInfo.spec ../SRPMS/perl-Devel-StringInfo-0.04-1.fc18.src.rpm ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jun 22 15:04 /usr/share/doc/perl-Devel-StringInfo-0.04
-rw-r--r--    1 root    root                      160 May 14  2009 /usr/share/doc/perl-Devel-StringInfo-0.04/Changes
-rw-r--r--    1 root    root                     3365 Jun 22 15:04 /usr/share/man/man3/Devel::StringInfo.3pm.gz
drwxr-xr-x    2 root    root                        0 Jun 22 15:04 /usr/share/perl5/vendor_perl/Devel
-rw-r--r--    1 root    root                     7976 May 14  2009 /usr/share/perl5/vendor_perl/Devel/StringInfo.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Encode)
      1 perl(Encode::Guess)
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(Moose)
      1 perl(namespace::clean)
      1 perl(Scalar::Util)
      1 perl(Sub::Exporter)
      1 perl(Tie::IxHash)
      1 perl(utf8)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).

$ rpm -q --provides -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Devel::StringInfo) = 0.04
      1 perl-Devel-StringInfo = 0.04-1.fc18
Binary provides are Ok.

Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4188014). ???

Otherwise package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' prefix issues and provides new spec file.
Resolution: Package NOT approved.
Comment 2 Jitka Plesnikova 2012-06-22 09:42:55 EDT
Updated.

http://koji.fedoraproject.org/koji/taskinfo?taskID=4188205
Comment 3 Petr Pisar 2012-06-22 09:54:22 EDT
Spec file changes:
--- perl-Devel-StringInfo.spec.old      2012-06-22 10:00:53.000000000 +0200
+++ perl-Devel-StringInfo.spec  2012-06-22 15:41:42.000000000 +0200
@@ -2,7 +2,7 @@
 Version:        0.04
 Release:        1%{?dist}
 Summary:        Gather information about strings
-License:        GPL+ or Artistic
+License:        GPL+ or Artistic or MIT
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Devel-StringInfo/
 Source0:        http://www.cpan.org/authors/id/N/NU/NUFFIN/Devel-StringInfo-%{version}.tar.gz
@@ -20,6 +20,8 @@
 BuildRequires:  perl(Tie::IxHash)
 BuildRequires:  perl(YAML)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:       perl(Data::HexDump::XXD)
+Requires:       perl(YAML)

 %description
 This module is a debugging aid that helps figure out more information
@@ -33,8 +35,6 @@
 make %{?_smp_mflags}

 %install
-rm -rf $RPM_BUILD_ROOT
-
 make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT

 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;


> FIX: Add `or MIT' to the licenses (lib/Devel/StringInfo.pm).
-License:        GPL+ or Artistic
+License:        GPL+ or Artistic or MIT
Ok.

> FIX: Run-require `perl(YAML)' (lib/Devel/StringInfo.pm:77).
+Requires:       perl(YAML)
Ok.

> FIX: Run-require `perl(Data::HexDump::XXD)' (lib/Devel/StringInfo.pm:91).
+Requires:       perl(Data::HexDump::XXD)
Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Devel-StringInfo-0.04-1.fc18.noarch.rpm |sort |uniq -c
      1 perl(Data::HexDump::XXD)
      1 perl(Encode)
      1 perl(Encode::Guess)
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(Moose)
      1 perl(namespace::clean)
      1 perl(Scalar::Util)
      1 perl(Sub::Exporter)
      1 perl(Tie::IxHash)
      1 perl(utf8)
      1 perl(YAML)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4188268). Ok.

Resolution: Package APPROVED.
Comment 4 Jitka Plesnikova 2012-06-22 10:05:01 EDT
New Package SCM Request
=======================
Package Name: perl-Devel-StringInfo
Short Description: Gather information about strings
Owners: jplesnik mmaslano ppisar psabata
Branches:
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2012-06-22 10:25:24 EDT
Git done (by process-git-requests).
Comment 6 Jitka Plesnikova 2012-06-22 10:42:02 EDT
Thank you for the review and the repository.
Comment 7 Lubomir Rintel 2014-03-03 09:56:14 EST
Package Change Request
======================
Package Name: perl-Devel-StringInfo
New Branches: epel7
Owners: lkundrak

The Fedora maintainer is unfortunately not maintaining EPEL packages:
http://fedoraproject.org/wiki/EPEL/ContributorStatusNo
Comment 8 Gwyn Ciesla 2014-03-03 10:24:40 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.