Bug 837666

Summary: Review Request: php-doctrine-DoctrineCommon - Doctrine Common PHP Extensions
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, notting, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-28 03:48:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 517641    
Bug Blocks: 837668, 837669    
Attachments:
Description Flags
phpci.log
none
php-doctrine-DoctrineCommon-review.txt none

Description Shawn Iwinski 2012-07-04 16:14:04 UTC
Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineCommon.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineCommon-2.2.2-1.fc17.src.rpm

Description:
The Doctrine Common project is a library that provides extensions to core
PHP functionality.

Fedora Account System Username: siwinski

Comment 1 Shawn Iwinski 2012-07-04 16:31:24 UTC
rpmlint outputs the following error:

php-doctrine-DoctrineCommon.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineCommon/LICENSE

There is only whitespace and mailing address differences.  I will work with upstream to get this fixed.  Is this a blocker until it is fixed upstream?  http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not.

Comment 2 Shawn Iwinski 2012-07-07 01:38:28 UTC
DoctrineCommon (actually all Doctrine projects) is changing from LGPL license to MIT license in future release.

See:
* https://groups.google.com/d/topic/doctrine-dev/1TfuNPiRvks/discussion
* https://github.com/doctrine/common/commit/8b403cde97eaede30bd79acab4f18895fd5bdf27

Comment 3 Remi Collet 2012-10-29 06:50:33 UTC
Could you update to latest version 2.3.0 before I do a formal review ?

Comment 4 Shawn Iwinski 2012-11-28 01:50:37 UTC
- Updated to upstream version 2.3.0
- Added "%global pear_metadir" and usage in %install
- Added php-json require
- Updated %description
- PEAR package.xml fixes in %prep
- Changed RPM_BUILD_ROOT to %{buildroot}


Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineCommon.spec

SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineCommon-2.3.0-1.fc17.src.rpm

Comment 5 Shawn Iwinski 2012-11-28 01:58:43 UTC
(In reply to comment #4)

Correct changelog:
- Updated to upstream version 2.3.0
- Updated license from LGPLv2 to MIT
- Added "%global pear_metadir" and usage in %install
- Changed RPM_BUILD_ROOT to %{buildroot}

Comment 6 Remi Collet 2012-12-16 07:21:23 UTC
Created attachment 664221 [details]
phpci.log

Thanks to fedora-review-phpci

Comment 7 Remi Collet 2012-12-16 07:22:03 UTC
Created attachment 664222 [details]
php-doctrine-DoctrineCommon-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 837666

Comment 8 Remi Collet 2012-12-16 07:23:55 UTC
Please consider dropping the Zend Server from the description. This is not an OpenSource software and it will never be available in fedora repo.


No blocker.

=== APPROVED ===

Comment 9 Shawn Iwinski 2012-12-16 07:41:38 UTC
THANKS for the review!  I'll remove the Zend Server text from the description after initial import.

Where is "fedora-review-phpci"?  Seems like something you are currently developing? -- since I know I have the same version of "fedora-review".


New Package SCM Request
=======================
Package Name: php-doctrine-DoctrineCommon
Short Description: Doctrine Common PHP Extensions
Owners: siwinski
Branches: f17 f18 el6
InitialCC:

Comment 10 Gwyn Ciesla 2012-12-16 23:55:52 UTC
Git done (by process-git-requests).

Comment 11 Fedora Update System 2012-12-19 02:27:58 UTC
php-doctrine-DoctrineCommon-2.3.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.el6

Comment 12 Fedora Update System 2012-12-19 02:28:10 UTC
php-doctrine-DoctrineCommon-2.3.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc18

Comment 13 Fedora Update System 2012-12-19 02:28:20 UTC
php-doctrine-DoctrineCommon-2.3.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc17

Comment 14 Fedora Update System 2012-12-19 18:33:10 UTC
Package php-doctrine-DoctrineCommon-2.3.0-2.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing php-doctrine-DoctrineCommon-2.3.0-2.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-13801/php-doctrine-DoctrineCommon-2.3.0-2.el6
then log in and leave karma (feedback).

Comment 15 Fedora Update System 2012-12-28 03:48:35 UTC
php-doctrine-DoctrineCommon-2.3.0-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 16 Fedora Update System 2013-01-04 19:40:20 UTC
php-doctrine-DoctrineCommon-2.3.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 17 Fedora Update System 2013-01-12 00:47:56 UTC
php-doctrine-DoctrineCommon-2.3.0-2.fc18 has been pushed to the Fedora 18 stable repository.