Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineCommon.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineCommon-2.2.2-1.fc17.src.rpm Description: The Doctrine Common project is a library that provides extensions to core PHP functionality. Fedora Account System Username: siwinski
rpmlint outputs the following error: php-doctrine-DoctrineCommon.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineCommon/LICENSE There is only whitespace and mailing address differences. I will work with upstream to get this fixed. Is this a blocker until it is fixed upstream? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not.
DoctrineCommon (actually all Doctrine projects) is changing from LGPL license to MIT license in future release. See: * https://groups.google.com/d/topic/doctrine-dev/1TfuNPiRvks/discussion * https://github.com/doctrine/common/commit/8b403cde97eaede30bd79acab4f18895fd5bdf27
Could you update to latest version 2.3.0 before I do a formal review ?
- Updated to upstream version 2.3.0 - Added "%global pear_metadir" and usage in %install - Added php-json require - Updated %description - PEAR package.xml fixes in %prep - Changed RPM_BUILD_ROOT to %{buildroot} Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineCommon.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineCommon-2.3.0-1.fc17.src.rpm
(In reply to comment #4) Correct changelog: - Updated to upstream version 2.3.0 - Updated license from LGPLv2 to MIT - Added "%global pear_metadir" and usage in %install - Changed RPM_BUILD_ROOT to %{buildroot}
Created attachment 664221 [details] phpci.log Thanks to fedora-review-phpci
Created attachment 664222 [details] php-doctrine-DoctrineCommon-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 837666
Please consider dropping the Zend Server from the description. This is not an OpenSource software and it will never be available in fedora repo. No blocker. === APPROVED ===
THANKS for the review! I'll remove the Zend Server text from the description after initial import. Where is "fedora-review-phpci"? Seems like something you are currently developing? -- since I know I have the same version of "fedora-review". New Package SCM Request ======================= Package Name: php-doctrine-DoctrineCommon Short Description: Doctrine Common PHP Extensions Owners: siwinski Branches: f17 f18 el6 InitialCC:
Git done (by process-git-requests).
php-doctrine-DoctrineCommon-2.3.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.el6
php-doctrine-DoctrineCommon-2.3.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc18
php-doctrine-DoctrineCommon-2.3.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineCommon-2.3.0-2.fc17
Package php-doctrine-DoctrineCommon-2.3.0-2.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing php-doctrine-DoctrineCommon-2.3.0-2.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-13801/php-doctrine-DoctrineCommon-2.3.0-2.el6 then log in and leave karma (feedback).
php-doctrine-DoctrineCommon-2.3.0-2.fc17 has been pushed to the Fedora 17 stable repository.
php-doctrine-DoctrineCommon-2.3.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
php-doctrine-DoctrineCommon-2.3.0-2.fc18 has been pushed to the Fedora 18 stable repository.