Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineORM.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineORM-2.2.2-1.fc17.src.rpm Description: Object relational mapper (ORM) for PHP that sits on top of a powerful database abstraction layer (DBAL). One of its key features is the option to write database queries in a proprietary object oriented SQL dialect called Doctrine Query Language (DQL), inspired by Hibernate's HQL. This provides developers with a powerful alternative to SQL that maintains flexibility without requiring unnecessary code duplication. Fedora Account System Username: siwinski
rpmlint outputs the following: php-doctrine-DoctrineORM.noarch: E: script-without-shebang /usr/bin/doctrine.php php-doctrine-DoctrineORM.noarch: E: script-without-shebang /usr/bin/doctrine.bat php-doctrine-DoctrineORM.noarch: E: incorrect-fsf-address /usr/share/doc/pear/DoctrineORM/LICENSE php-doctrine-DoctrineORM.noarch: E: zero-length /usr/share/doc/pear/DoctrineORM/Doctrine/ORM/README.markdown php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine.php php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine.bat php-doctrine-DoctrineORM.noarch: W: no-manual-page-for-binary doctrine * I will fix script-without-shebang according to http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang * Since this is a PEAR package and all files are listed in package.xml, are zero-length errors required to be fixed? * incorrect-fsf-address: There is only whitespace and mailing address differences. I will work with upstream to get this fixed. Is this a blocker until it is fixed upstream? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is not clear if this is a blocker or not. * I will ask upstream to fix no-manual-page-for-binary warnings Also, I will work with upstream to update their package.xml file so doctrine.bat only gets installed on Windows OS (using phprelease and installconditions) like several other PEAR packages do (phpci for example).
(In reply to comment #1) > * I will fix script-without-shebang according to > http://fedoraproject.org/wiki/Common_Rpmlint_issues#script-without-shebang If I remove the execute mode bit from /usr/bin/doctrine.php, rpmlint gives the warning "non-executable-in-bin /usr/bin/doctrine.php 0644L". How should this file be handled? > * incorrect-fsf-address: There is only whitespace and mailing address > differences. I will work with upstream to get this fixed. Is this a > blocker until it is fixed upstream? > http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address is > not clear if this is a blocker or not. DoctrineORM (actually all Doctrine projects) is changing from LGPL license to MIT license in future release. See: * https://groups.google.com/d/topic/doctrine-dev/1TfuNPiRvks/discussion * http://dlm.beberlei.de/licenses/projects * https://github.com/doctrine/doctrine2/commit/70458b2f48eba9a7e184aef95741aad4865b73e5
- Updated to 2.3.3 - Fixed license - Added php-dom require - Made a single executable (removed doctrine-pear.php) - Removed doctrine.bat - Added "%global pear_metadir" and usage in %install - Changed RPM_BUILD_ROOT to %{buildroot} Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-doctrine-DoctrineORM.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-doctrine-DoctrineORM-2.3.3-1.fc18.src.rpm
Created attachment 766800 [details] phpci.log phpcompatinfo version 2.18.0.
Created attachment 766801 [details] review.txt Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 837669
Awfull package.xml juggling... hope upstream will care of that (which doesn't really seems the case reading your 6 months old bug report).. Therefore the fix is wanted and correct. No blocker. === APPROVED ===
THANKS for the review! New Package SCM Request ======================= Package Name: php-doctrine-DoctrineORM Short Description: Doctrine Object Relational Mapper Owners: siwinski Branches: f18 f19 el6 InitialCC:
Git done (by process-git-requests).
php-doctrine-DoctrineORM-2.3.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineORM-2.3.3-1.fc19
php-doctrine-DoctrineORM-2.3.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineORM-2.3.3-1.el6
php-doctrine-DoctrineORM-2.3.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-doctrine-DoctrineORM-2.3.3-1.fc18
php-doctrine-DoctrineORM-2.3.3-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-doctrine-DoctrineORM-2.3.3-1.fc19 has been pushed to the Fedora 19 stable repository.
php-doctrine-DoctrineORM-2.3.3-1.fc18 has been pushed to the Fedora 18 stable repository.
php-doctrine-DoctrineORM-2.3.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository.