Bug 845277
| Summary: | JBoss ON dashboard shows messed metric graph on IE 8/9 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Amana <ajuricic> | ||||||
| Component: | UI | Assignee: | Mike Thompson <mithomps> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | urgent | ||||||||
| Version: | JON 3.1.2 | CC: | jkremser, loleary, mithomps, skondkar, spinder | ||||||
| Target Milestone: | CR03 | ||||||||
| Target Release: | JON 3.1.2 | ||||||||
| Hardware: | All | ||||||||
| OS: | Windows | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 852837 (view as bug list) | Environment: | |||||||
| Last Closed: | 2013-09-11 11:03:55 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 852837 | ||||||||
| Bug Blocks: | 880594 | ||||||||
| Attachments: |
|
||||||||
|
Description
Amana
2012-08-02 14:29:54 UTC
Created attachment 602534 [details]
Screenshot - Broken graph on dashboard
Screen-shot showing how the broken graph looks on the Dashboard. The graph points appear to be missing and the axis labels are misplaced.
Created attachment 602535 [details]
Screenshot - Working graph on Monitoring > Graphs view
Screen-shot showing the same graph working on the resource's Monitoring > Graphs view tab.
Same issue affects both IE 8 and IE 9. Reproduced with the following versions:
Version: 9.0.8112.16421
Version: 8.0.6001.18702
mtho11_lunch: can you provide some initial comments on https://bugzilla.redhat.com/show_bug.cgi?id=845277 The charts use the gflot library, which internally uses the <CANVAS> element (not supported in IE8/9). Fortunately, there are some workarounds. The most promising are excanvas http://code.google.com/p/explorercanvas/ and GWTCanvas from GWT Incubator (http://code.google.com/p/google-web-toolkit-incubator/wiki/GWTCanvas). The former one is more mature. Currently we use gflot in version 1.0.0. There is 2.4.2 version present in Maven Central. It seems like the newest version has built-in support for excanvas, but the API has been slightly modified (just some refactoring, nothing serious). So I am trying to upgrade the version of gflot, master time: Wed Aug 15 19:42:24 2012 +0200 commit: 5d243b30f5315f18329f6f4fa9db22ae47eb32bd author: Jirka Kremser - jkremser message: [BZ 845277 - JBoss ON dashboard shows messed metric graph on IE 8/9] Version of gflot upgraded to 2.4.2 (it contains the excanvas library for IE8/9 support of HTML canvas el.), version of sparkline upgraded to 2.0, version of jquery upgraded to 1.7.2 http://git.fedorahosted.org/cgit/rhq/rhq.git/diff/?id=5d243b3 http://git.fedorahosted.org/cgit/rhq/rhq.git/diff/?id=8000e71 master time: Wed Aug 15 20:13:14 2012 +0200 commit: 8000e712dd98fd8ee8e1ff52940e15b07f11e782 author: Jirka Kremser - jkremser message: [BZ 845277] - quick fix: removed the doctype declaration and removed overcasting to int I have verified the fix for IE8 and reviewed solution. Moving back to ON_DEV as this has not yet been committed to JON 3.1.2 and will need to wait for the release/jon3.1.x branch to be open for 3.1.2 commits. Once open, the master commit should be cherry-picked. http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=b9d4a5f99 branch: release/jon3.1.x time: Fri Nov 2 15:50:33 2012 +0100 commit: b9d4a5f99ebc403ad169f7da26a04a6877c95dfa author: Jirka Kremser - jkremser message: [BZ 845277 - JBoss ON dashboard shows messed metric graph on IE 8/9] Version of gflot upgraded to 2.4.2 (it contains the excanvas library for IE8/9 support of HTML canvas el.), version of sparkline upgraded to 2.0, version of jquery upgraded to 1.7.2; quick fix: removed the doctype declaration and removed overcasting to int (cherry-picked and merged into one commit from 5d243b3 and 8000e71) changing status to MODIFIED Moving this to ON_QA as available for testing in https://brewweb.devel.redhat.com//buildinfo?buildID=243389. Verified on JON 3.1.2 CR2 build. Verified on IE9 and IE8 (IE 9.0.8112.16421 and IE 8.0.6001.18702) Followed the steps and verified that metric graphs for resources selected in 'Resource Metric Graph' and 'Resource Group Metric' portlets are displayed correctly. Also verified that the icon in the Resource Metric Graph portlet (to view the live graph of current values) displays correct graph. Looks like the fix for this issue has introduced a very bad regression. Bug 894319 identifies the new bug that this fix introduced. Based on the deprecated status of IE8 and the continued effort necessary to add support for IE9, we may end up backing this fix out and re-targeting to 3.2. As per bug triage meeting today, this fix needs to be backed out due to the fact that it breaks sparkline graphs as described in bug 864319. Re-assigned to Mike Thompson and status updated to ASSIGNED. This is blocking for the 3.1.2.CR3 build. Fixed with BZ 894319. No need to back out as fix is true to fix BZ 894319 and it now no longer breaks this BZ so we can leave it in. In fact, it was reverted earlier and is now put back in with release/jon3.1.x commit: http://git.fedorahosted.org/cgit/rhq/rhq.git/diff/?id=8c1226a9b Needs to be retested. Verified on JON 3.1.2 CR3 build. Followed the steps and verified that the portlets display correct metric graphs. Verified on IE9 and IE8 (IE 9.0.8112.16421 and IE 8.0.6001.18702) |